Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tabstop keymap handling with a minor mode / overlay #12281

Open
the-mikedavis opened this issue Dec 17, 2024 · 0 comments
Open

Replace tabstop keymap handling with a minor mode / overlay #12281

the-mikedavis opened this issue Dec 17, 2024 · 0 comments
Labels
A-keymap Area: Keymap and keybindings C-enhancement Category: Improvements

Comments

@the-mikedavis
Copy link
Member

The snippet tabstop PR #9801 added some minor ad-hoc keymap handling code to allow transitioning between tabstops. Some early review mentioned using minor modes as a sort of overlay on the current keymap to overwrite the tab binding instead #9801 (comment). This is preferrable but larger in scope than the code added in #9801. We should replace the ad-hoc stuff with an overlay/minor-mode once we refactor minor modes to be capable of layering on other modes.

@the-mikedavis the-mikedavis added C-enhancement Category: Improvements A-keymap Area: Keymap and keybindings labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-keymap Area: Keymap and keybindings C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

1 participant