Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking Predictive Displayshould uncheck FollowGripper, and vice versa #46

Open
hello-amal opened this issue May 22, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@hello-amal
Copy link
Collaborator

Description

In Predictive Display, the "straight" always seems to be rendered towards the top of the screen. This is only accurate when the head camera is looking at the base. For example, see the below images. In the first one predictive display works because it is looking at the base, but in the second, the head camera is following the gripper, and hence predictive display doesn't work.

Screenshot 2024-05-21 at 5 21 13 PM (2) Screenshot 2024-05-21 at 5 21 22 PM (2)

Options for addressing it

  1. [Preferred] When the user checks predictive display, the head camera should automatically look at base.
  2. The predictive display checkbox should be disabled if the head camera is not looking at the base. (Non-ideal because it may be unclear for the user why it is disabled.)
  3. Update predictive display to work regardless of where the head camera is facing. This is the most sustainable solution, but would require considerable camera projection / matrix multiplication. Plus, if the camera is not looking at the base at all, predictive display would effectively be disabled.
@hello-amal hello-amal added the bug Something isn't working label May 22, 2024
@hello-amal
Copy link
Collaborator Author

hello-amal commented May 22, 2024

Addendum to Option 1 based on a discussion with @hello-vinitha : When the user checks predictive display, it does rotate the head camera to the base, except follow gripper overrides it. So perhaps the quick bugfix is to also have it automatially un-check "Follow gripper"

@hello-amal hello-amal changed the title Predictive Display doesn't work unless the head camera is looking at the base Checking Predictive Displayshould uncheck FollowGripper, and vice versa Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant