Skip to content

Commit 573c5c2

Browse files
committed
Better training style spinner, code cleanup
1 parent 1939d53 commit 573c5c2

File tree

8 files changed

+303
-282
lines changed

8 files changed

+303
-282
lines changed

src/app/build.gradle.kts

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,12 @@ android {
1010
applicationId = "com.helloyanis.rucoycalculator"
1111
minSdk = 24
1212
targetSdk = 35
13-
versionCode = 83
14-
versionName = "8.3"
13+
versionCode = 84
14+
versionName = "8.4"
1515

1616
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
1717
}
1818

19-
buildTypes {
20-
release {
21-
isMinifyEnabled = false
22-
proguardFiles(
23-
getDefaultProguardFile("proguard-android-optimize.txt"),
24-
"proguard-rules.pro"
25-
)
26-
}
27-
}
2819
compileOptions {
2920
sourceCompatibility = JavaVersion.VERSION_1_8
3021
targetCompatibility = JavaVersion.VERSION_1_8
@@ -42,7 +33,10 @@ android {
4233
androidResources {
4334
generateLocaleConfig = true
4435
}
45-
36+
dependenciesInfo {
37+
includeInApk = false
38+
includeInBundle = false
39+
}
4640
}
4741

4842
dependencies {

src/app/proguard-rules.pro

Lines changed: 0 additions & 21 deletions
This file was deleted.

src/app/src/main/java/com/helloyanis/rucoycalculator/ui/train/TrainFragment.kt

Lines changed: 81 additions & 92 deletions
Large diffs are not rendered by default.

src/app/src/main/res/layout/train.xml

Lines changed: 17 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
android:hint="@string/base_level"
2929
app:layout_constraintEnd_toEndOf="parent"
3030
app:layout_constraintStart_toStartOf="parent"
31-
app:layout_constraintTop_toBottomOf="@+id/trainstylespinner">
31+
app:layout_constraintTop_toBottomOf="@+id/trainstylespinnerLayout">
3232

3333
<com.google.android.material.textfield.TextInputEditText
3434
android:id="@+id/baselevel"
@@ -96,13 +96,14 @@
9696

9797
<com.google.android.material.textfield.TextInputLayout
9898
android:id="@+id/tickLayout"
99-
android:layout_width="200dp"
99+
android:layout_width="0dp"
100100
android:layout_height="wrap_content"
101101
android:ems="10"
102102
android:hint="@string/tick"
103-
android:imeActionLabel="Test"
104103
android:inputType="number"
105104
android:visibility="gone"
105+
app:helperText="@string/tickrate_tooltip"
106+
app:layout_constraintEnd_toEndOf="parent"
106107
app:layout_constraintStart_toStartOf="parent"
107108
app:layout_constraintTop_toBottomOf="@+id/weaponatkLayout"
108109
tools:visibility="visible">
@@ -122,7 +123,6 @@
122123
android:width="200dp"
123124
android:ems="10"
124125
android:hint="@string/stat_goal"
125-
android:imeActionLabel="Test"
126126
android:visibility="gone"
127127
app:layout_constraintEnd_toEndOf="parent"
128128
app:layout_constraintStart_toStartOf="parent"
@@ -145,40 +145,26 @@
145145
app:layout_constraintStart_toStartOf="parent"
146146
app:layout_constraintTop_toBottomOf="@+id/critring" />
147147

148-
<Spinner
149-
android:id="@+id/trainstylespinner"
148+
<com.google.android.material.textfield.TextInputLayout
149+
android:id="@+id/trainstylespinnerLayout"
150150
android:layout_width="0dp"
151151
android:layout_height="wrap_content"
152-
android:entries="@array/train_methods_array"
153-
android:spinnerMode="dialog"
154-
android:theme="@style/Theme.RucoyCalculator"
155152
app:layout_constraintBottom_toBottomOf="@+id/showtutorial"
156153
app:layout_constraintEnd_toStartOf="@+id/showtutorial"
157154
app:layout_constraintStart_toStartOf="parent"
158-
app:layout_constraintTop_toBottomOf="@+id/divider2"
159-
app:layout_constraintTop_toTopOf="parent" />
155+
app:layout_constraintTop_toTopOf="parent"
156+
style="@style/Widget.Material3.TextInputLayout.FilledBox.ExposedDropdownMenu">
160157

161-
<Button
162-
android:id="@+id/tickhelp"
163-
android:layout_width="0dp"
164-
android:layout_height="wrap_content"
165-
android:text="@string/tickrate_help"
166-
android:visibility="gone"
167-
app:layout_constraintBottom_toBottomOf="@+id/tickLayout"
168-
app:layout_constraintEnd_toEndOf="parent"
169-
app:layout_constraintStart_toEndOf="@+id/tickLayout"
170-
app:layout_constraintTop_toBottomOf="@+id/weaponatkLayout"
171-
tools:visibility="visible" />
158+
<AutoCompleteTextView
159+
android:id="@+id/trainstylespinner"
160+
android:layout_width="match_parent"
161+
android:layout_height="wrap_content"
162+
android:background="@android:color/transparent"
163+
android:inputType="none"
164+
app:simpleItems="@array/train_methods_array"
165+
android:theme="@style/Theme.RucoyCalculator" />
166+
</com.google.android.material.textfield.TextInputLayout>
172167

173-
<View
174-
android:id="@+id/divider2"
175-
android:layout_width="0dp"
176-
android:layout_height="wrap_content"
177-
android:background="?android:attr/listDivider"
178-
app:layout_constraintEnd_toEndOf="parent"
179-
app:layout_constraintHorizontal_bias="0.0"
180-
app:layout_constraintStart_toStartOf="parent"
181-
tools:layout_editor_absoluteY="48dp" />
182168

183169
<Spinner
184170
android:id="@+id/mobspinner"

src/gradle/wrapper/gradle-wrapper.jar

-15.3 KB
Binary file not shown.
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
#Wed Feb 12 10:04:22 CET 2025
21
distributionBase=GRADLE_USER_HOME
32
distributionPath=wrapper/dists
3+
distributionSha256Sum=8d97a97984f6cbd2b85fe4c60a743440a347544bf18818048e611f5288d46c94
44
distributionUrl=https\://services.gradle.org/distributions/gradle-8.12.1-bin.zip
5+
networkTimeout=10000
6+
validateDistributionUrl=true
57
zipStoreBase=GRADLE_USER_HOME
68
zipStorePath=wrapper/dists

0 commit comments

Comments
 (0)