Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove command test broken #115

Open
asmello opened this issue Oct 10, 2023 · 0 comments
Open

Remove command test broken #115

asmello opened this issue Oct 10, 2023 · 0 comments
Labels
bug Reports or fixes associated with bugs in this project complexity::low Issues or ideas with a low implementation cost component::cli Everything related to the buffrs cli priority::high Urgent change or idea, please review quickly
Milestone
Stabilization

Comments

@asmello
Copy link
Contributor

asmello commented Oct 10, 2023

The filesystem template for the remove command test is missing files in the proto/vendor path so it should fail (and currently doesn't due to a bug in the main code.

https://github.com/helsing-ai/buffrs/blob/main/src/command.rs#L121

The call to .ok() silently drops the error.
@asmello asmello added bug Reports or fixes associated with bugs in this project complexity::low Issues or ideas with a low implementation cost component::cli Everything related to the buffrs cli priority::high Urgent change or idea, please review quickly labels Oct 10, 2023
@asmello asmello added this to the Stabilization milestone Oct 10, 2023
@asmello asmello mentioned this issue Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Reports or fixes associated with bugs in this project complexity::low Issues or ideas with a low implementation cost component::cli Everything related to the buffrs cli priority::high Urgent change or idea, please review quickly
Projects
Buffrs
Status: No status
Milestone
Stabilization
Development

No branches or pull requests
1 participant
@asmello