Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The generator code for Protoc inlines constants #146

Open
mara-schulke opened this issue Oct 20, 2023 · 1 comment
Open

The generator code for Protoc inlines constants #146

mara-schulke opened this issue Oct 20, 2023 · 1 comment
Assignees
@mara-schulke
Labels
bug Reports or fixes associated with bugs in this project complexity::low Issues or ideas with a low implementation cost component::cli Everything related to the buffrs cli priority::medium This is not urgent, but we should do this.
Milestone
Stabilization

Comments

@mara-schulke
Copy link
Contributor

https://github.com/helsing-ai/buffrs/blob/main/src/generator.rs#95

The code above should use store constants rather than inlining string literals
@mara-schulke mara-schulke added bug Reports or fixes associated with bugs in this project complexity::low Issues or ideas with a low implementation cost component::cli Everything related to the buffrs cli priority::medium This is not urgent, but we should do this. labels Oct 20, 2023
@mara-schulke mara-schulke self-assigned this Oct 20, 2023
@mara-schulke mara-schulke added this to the Stabilization milestone Oct 20, 2023
@Leopard2A5
Copy link
Contributor

That link is not valid anymore. Is the issue still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mara-schulke mara-schulke

Labels
bug Reports or fixes associated with bugs in this project complexity::low Issues or ideas with a low implementation cost component::cli Everything related to the buffrs cli priority::medium This is not urgent, but we should do this.
Projects
Buffrs
Status: No status
Milestone
Stabilization
Development

No branches or pull requests
2 participants
@Leopard2A5 @mara-schulke