test: require the invalid conpty bundle diagnostic

refs #3651

Author: JJLiebig

.github/workflows/ci.yml

@@ -196,8 +196,7 @@ jobs:
                 -ExePath $exe `
                 -Session "ci-conpty-invalid-windows-2022-$env:GITHUB_RUN_ID-$env:GITHUB_RUN_ATTEMPT"
             } catch {
-              if ($_.Exception.Message -notlike "workspace create failed with exit code*" -and
-                  $_.Exception.Message -notlike "server exited with exit code*") {
+                if ($_.Exception.Message -notlike "*Herdr's app-local ConPTY bundle is invalid:*") {
                 throw
               }
               $rejected = $true

scripts/windows_smoke_conpty_path.ps1

@@ -101,7 +101,8 @@ try {
         $ErrorActionPreference = $savedErrorActionPreference
     }
     if ($createdExitCode -ne 0) {
-        throw "workspace create failed with exit code $createdExitCode`: $($created -join "`n")"
+        $serverError = Get-Content -LiteralPath $serverErrorPath -Raw
+        throw "workspace create failed with exit code $createdExitCode`: $($created -join "`n")`n$serverError"
     }
     $paneId = (($created -join "`n") | ConvertFrom-Json).result.root_pane.pane_id
     if ([string]::IsNullOrWhiteSpace($paneId)) {