Skip to content

Peer to peer code review #25

Description

@Alejandroq12

Julio

Great job Hernán. I like the way the project is working.

The make your project even better you may consider the following suggestions:

Add aria-label to anchor elements (), e.g., < a href="#cards-section" id="poke-count" aria-label="Pokemons Section" >Pokemons.

numbOfLikes.js
You're mixing then() and async/await syntax. it could be great if you consider using async/await consistently to make the code more readable and maintainable.
Add try/catch blocks to handle errors that might occur during API calls.

Great job! And very good project. I like it.

Juan

Good job there guys, the app looks really nice.

  • The code looks professional and well orginized.

  • I think you could separate numOfLikes into two modules so you can export
    1 function per module. You can give a try if it works for you 👍

  • Nice work linking your GitHub profiles on the footer section.

Mahdi

Javascript-Capstone/src/modules/fetchingData.js

does not have a closing tag

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions