Skip to content

Commit

Permalink
fixup
Browse files Browse the repository at this point in the history
  • Loading branch information
marco-ippolito committed Dec 11, 2024
1 parent 9cf1517 commit 9718bb0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 11 deletions.
2 changes: 1 addition & 1 deletion libs/report/ingestion/src/lib/ingestion-manifest.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ describe('Telemetry Functions', () => {

expect(result).toBeUndefined();
expect(consoleWarnSpy).toHaveBeenCalledWith(
`[WARN] Ignoring file ${mockFileName}, because is empty`
`[WARN] Ignoring file ${mockFileName}, because it is empty`
);
consoleWarnSpy.mockRestore();
});
Expand Down
13 changes: 3 additions & 10 deletions libs/report/ingestion/src/lib/ingestion-prompt.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe('askConsent', () => {
const result = await askConsent(args);

expect(consoleSpy).toHaveBeenCalledWith(
'Data may contain sensitive data, please review before sharing it.'
'Data may contain sensitive information, please review before sharing it.'
);
expect(result).toBe(true);

Expand All @@ -28,7 +28,7 @@ describe('askConsent', () => {
const result = await askConsent(args);

expect(confirm).toHaveBeenCalledWith({
message: 'Data may contain sensitive data, please review before sharing it. Continue?',
message: 'Data may contain sensitive information, please review before sharing it. Continue?',
});
expect(result).toBe(true);
});
Expand All @@ -40,7 +40,7 @@ describe('askConsent', () => {
const result = await askConsent(args);

expect(confirm).toHaveBeenCalledWith({
message: 'Data may contain sensitive data, please review before sharing it. Continue?',
message: 'Data may contain sensitive information, please review before sharing it. Continue?',
});
expect(result).toBe(false);
});
Expand All @@ -59,13 +59,6 @@ describe('promptClientName', () => {
});
expect(result).toBe(mockName);
});

it('should validate the input and reject empty names', async () => {
const validateFn = (input as jest.Mock).mock.calls[0][0].validate;
expect(validateFn('')).toBe('Name cannot be empty!');
expect(validateFn(' ')).toBe('Name cannot be empty!');
expect(validateFn('Valid Name')).toBe(true);
});
});

describe('promptToProceedUploadFile', () => {
Expand Down

0 comments on commit 9718bb0

Please sign in to comment.