Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the lack of client code #14

Open
cqqqq777 opened this issue Mar 13, 2023 · 5 comments
Open

the lack of client code #14

cqqqq777 opened this issue Mar 13, 2023 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@cqqqq777
Copy link

当我使用hertz-contrib/websocket时发现缺少了一些客户端的方法,类似gorilla/websocket中的Dial方法:https://github.com/gorilla/websocket/blob/master/client.go#L116
image

希望在以后的维护中可以加入有关客户端的方法

@welkeyever welkeyever added enhancement New feature or request good first issue Good for newcomers labels Mar 13, 2023
@welkeyever
Copy link

Currently, we may not have enough time to put into this.
I will put the good first issue tag for it first.
If you are interested in it, any PR is welcome.

@shivamganwani
Copy link

shivamganwani commented Apr 29, 2023

@welkeyever I am new to open source and I had to translate what @cqqqq777 said.
So just to confirm that I have understood correctly.
We need to add missing client methods in hertz-contrib/websocket, and I can refer to gorilla/websocket. One of them in Dial but we might need others as well.
Please tell me if there is anything else in the req.

@welkeyever
Copy link

@shivamganwani Sorry for the late, I just came back from vacation.
Yes, it is open to do so like your said - mostly the dial and related APIs - regarding gorilla/websocket.
Let me know if you are interested in it, and I will assign it to you🫡

@qleein
Copy link

qleein commented Oct 18, 2023

@welkeyever I want to patch hertz/contrib/websocket to support websocket client,based on hertz client,but found it is difficult. because the hertz client do not provide any function to access current connection after response 101 and switch protocol to websocket. what i can do is reading body streamly. Is there any suggestion?

@welkeyever
Copy link

@qleein Good point! It seems like we need to open a door for client to hijack the connection. If you are interested in the follow-up and task dismantling, you may lit up an issue here, and do it. Or I will come back later and take a closer look after the things at hand are over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants