From b058d9b6dd2feda8a79d85adc634a4583675f669 Mon Sep 17 00:00:00 2001 From: jaguililla Date: Thu, 2 Nov 2023 13:56:18 +0100 Subject: [PATCH 1/3] Set next release version --- gradle.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gradle.properties b/gradle.properties index a4c3e6f5de..e2b869ecd8 100644 --- a/gradle.properties +++ b/gradle.properties @@ -5,7 +5,7 @@ org.gradle.warning.mode=all org.gradle.console=plain # Gradle -version=3.4.1 +version=3.4.2 group=com.hexagonkt description=The atoms of your platform From 60700bf81f6d16f64d1654a4b4fafd5c698315e8 Mon Sep 17 00:00:00 2001 From: jaguililla Date: Fri, 3 Nov 2023 23:44:58 +0100 Subject: [PATCH 2/3] Refactor --- core/api/core.api | 13 ----- .../hexagonkt/core/logging/SystemLogger.kt | 2 +- .../api/http_server_netty.api | 10 ---- .../server/netty/HttpChannelInitializer.kt | 34 +++++++++++ .../server/netty/HttpsChannelInitializer.kt | 40 +++++++++++++ .../http/server/netty/NettyServerAdapter.kt | 57 ------------------- .../http/server/netty/NettyServerHandler.kt | 8 +-- 7 files changed, 79 insertions(+), 85 deletions(-) create mode 100644 http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/HttpChannelInitializer.kt create mode 100644 http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/HttpsChannelInitializer.kt diff --git a/core/api/core.api b/core/api/core.api index cc7684d42d..ac9c733e59 100644 --- a/core/api/core.api +++ b/core/api/core.api @@ -293,19 +293,6 @@ public abstract interface class com/hexagonkt/core/logging/LoggingPort { public abstract fun setLoggerLevel (Ljava/lang/String;Lcom/hexagonkt/core/logging/LoggingLevel;)V } -public final class com/hexagonkt/core/logging/SystemLogger : com/hexagonkt/core/logging/LoggerPort { - public fun (Ljava/lang/String;)V - public final fun component1 ()Ljava/lang/String; - public final fun copy (Ljava/lang/String;)Lcom/hexagonkt/core/logging/SystemLogger; - public static synthetic fun copy$default (Lcom/hexagonkt/core/logging/SystemLogger;Ljava/lang/String;ILjava/lang/Object;)Lcom/hexagonkt/core/logging/SystemLogger; - public fun equals (Ljava/lang/Object;)Z - public final fun getName ()Ljava/lang/String; - public fun hashCode ()I - public fun log (Lcom/hexagonkt/core/logging/LoggingLevel;Ljava/lang/Throwable;Lkotlin/jvm/functions/Function1;)V - public fun log (Lcom/hexagonkt/core/logging/LoggingLevel;Lkotlin/jvm/functions/Function0;)V - public fun toString ()Ljava/lang/String; -} - public final class com/hexagonkt/core/logging/SystemLoggingAdapter : com/hexagonkt/core/logging/LoggingPort { public fun ()V public fun (Lcom/hexagonkt/core/logging/LoggingLevel;)V diff --git a/core/src/main/kotlin/com/hexagonkt/core/logging/SystemLogger.kt b/core/src/main/kotlin/com/hexagonkt/core/logging/SystemLogger.kt index 3e42a51c8c..90eabed085 100644 --- a/core/src/main/kotlin/com/hexagonkt/core/logging/SystemLogger.kt +++ b/core/src/main/kotlin/com/hexagonkt/core/logging/SystemLogger.kt @@ -2,7 +2,7 @@ package com.hexagonkt.core.logging import com.hexagonkt.core.logging.LoggingLevel.* -data class SystemLogger(val name: String) : LoggerPort { +internal data class SystemLogger(val name: String) : LoggerPort { private val logger: System.Logger = System.getLogger(name) diff --git a/http/http_server_netty/api/http_server_netty.api b/http/http_server_netty/api/http_server_netty.api index 50bc746b70..7756e9de52 100644 --- a/http/http_server_netty/api/http_server_netty.api +++ b/http/http_server_netty/api/http_server_netty.api @@ -59,13 +59,3 @@ public class com/hexagonkt/http/server/netty/NettyServerAdapter : com/hexagonkt/ public fun supportedProtocols ()Ljava/util/Set; } -public final class com/hexagonkt/http/server/netty/NettyServerAdapter$HttpChannelInitializer : io/netty/channel/ChannelInitializer { - public fun (Ljava/util/Map;Lio/netty/util/concurrent/EventExecutorGroup;Lcom/hexagonkt/http/server/HttpServerSettings;)V - public synthetic fun initChannel (Lio/netty/channel/Channel;)V -} - -public final class com/hexagonkt/http/server/netty/NettyServerAdapter$HttpsChannelInitializer : io/netty/channel/ChannelInitializer { - public fun (Ljava/util/Map;Lio/netty/handler/ssl/SslContext;Lcom/hexagonkt/http/SslSettings;Lio/netty/util/concurrent/EventExecutorGroup;Lcom/hexagonkt/http/server/HttpServerSettings;)V - public synthetic fun initChannel (Lio/netty/channel/Channel;)V -} - diff --git a/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/HttpChannelInitializer.kt b/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/HttpChannelInitializer.kt new file mode 100644 index 0000000000..5c29512d1f --- /dev/null +++ b/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/HttpChannelInitializer.kt @@ -0,0 +1,34 @@ +package com.hexagonkt.http.server.netty + +import com.hexagonkt.http.handlers.HttpHandler +import com.hexagonkt.http.server.HttpServerSettings +import io.netty.channel.ChannelInitializer +import io.netty.channel.socket.SocketChannel +import io.netty.handler.codec.http.* +import io.netty.handler.stream.ChunkedWriteHandler +import io.netty.util.concurrent.EventExecutorGroup + +internal class HttpChannelInitializer( + private val handlers: Map, + private val executorGroup: EventExecutorGroup?, + private val settings: HttpServerSettings, +) : ChannelInitializer() { + + override fun initChannel(channel: SocketChannel) { + val pipeline = channel.pipeline() + + pipeline.addLast(HttpServerCodec()) +// pipeline.addLast(HttpServerKeepAliveHandler()) + pipeline.addLast(HttpObjectAggregator(Int.MAX_VALUE)) +// pipeline.addLast(ChunkedWriteHandler()) + + if (settings.zip) + pipeline.addLast(HttpContentCompressor()) + + val nettyServerHandler = NettyServerHandler(handlers, null) + if (executorGroup == null) + pipeline.addLast(nettyServerHandler) + else + pipeline.addLast(executorGroup, nettyServerHandler) + } +} diff --git a/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/HttpsChannelInitializer.kt b/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/HttpsChannelInitializer.kt new file mode 100644 index 0000000000..bdfdcafa96 --- /dev/null +++ b/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/HttpsChannelInitializer.kt @@ -0,0 +1,40 @@ +package com.hexagonkt.http.server.netty + +import com.hexagonkt.http.SslSettings +import com.hexagonkt.http.handlers.HttpHandler +import com.hexagonkt.http.server.HttpServerSettings +import io.netty.channel.ChannelInitializer +import io.netty.channel.socket.SocketChannel +import io.netty.handler.codec.http.* +import io.netty.handler.ssl.SslContext +import io.netty.util.concurrent.EventExecutorGroup + +internal class HttpsChannelInitializer( + private val handlers: Map, + private val sslContext: SslContext, + private val sslSettings: SslSettings, + private val executorGroup: EventExecutorGroup?, + private val settings: HttpServerSettings, +) : ChannelInitializer() { + + override fun initChannel(channel: SocketChannel) { + val pipeline = channel.pipeline() + val sslHandler = sslContext.newHandler(channel.alloc()) + val handlerSsl = if (sslSettings.clientAuth) sslHandler else null + + pipeline.addLast(sslHandler) + pipeline.addLast(HttpServerCodec()) +// pipeline.addLast(HttpServerKeepAliveHandler()) + pipeline.addLast(HttpObjectAggregator(Int.MAX_VALUE)) +// pipeline.addLast(ChunkedWriteHandler()) + + if (settings.zip) + pipeline.addLast(HttpContentCompressor()) + + val serverHandler = NettyServerHandler(handlers, handlerSsl) + if (executorGroup == null) + pipeline.addLast(serverHandler) + else + pipeline.addLast(executorGroup, serverHandler) + } +} diff --git a/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyServerAdapter.kt b/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyServerAdapter.kt index 13011ac6d0..c89144bde4 100644 --- a/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyServerAdapter.kt +++ b/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyServerAdapter.kt @@ -15,21 +15,17 @@ import com.hexagonkt.http.handlers.HttpHandler import io.netty.bootstrap.ServerBootstrap import io.netty.channel.* import io.netty.channel.nio.NioEventLoopGroup -import io.netty.channel.socket.SocketChannel import io.netty.channel.socket.nio.NioServerSocketChannel import io.netty.handler.codec.http.* import io.netty.handler.ssl.ClientAuth.OPTIONAL import io.netty.handler.ssl.ClientAuth.REQUIRE import io.netty.handler.ssl.SslContext import io.netty.handler.ssl.SslContextBuilder -import io.netty.handler.stream.ChunkedWriteHandler import io.netty.util.concurrent.DefaultEventExecutorGroup -import io.netty.util.concurrent.EventExecutorGroup import java.net.InetSocketAddress import java.util.concurrent.TimeUnit.SECONDS import javax.net.ssl.KeyManagerFactory import javax.net.ssl.TrustManagerFactory -import kotlin.Int.Companion.MAX_VALUE /** * Implements [HttpServerPort] using Netty [Channel]. @@ -196,57 +192,4 @@ open class NettyServerAdapter( NettyServerAdapter::shutdownQuietSeconds to shutdownQuietSeconds, NettyServerAdapter::shutdownTimeoutSeconds to shutdownTimeoutSeconds, ) - - class HttpChannelInitializer( - private val handlers: Map, - private val executorGroup: EventExecutorGroup?, - private val settings: HttpServerSettings, - ) : ChannelInitializer() { - - override fun initChannel(channel: SocketChannel) { - val pipeline = channel.pipeline() - - pipeline.addLast(HttpServerCodec()) - pipeline.addLast(HttpServerKeepAliveHandler()) - pipeline.addLast(HttpObjectAggregator(MAX_VALUE)) - pipeline.addLast(ChunkedWriteHandler()) - - if (settings.zip) - pipeline.addLast(HttpContentCompressor()) - - if (executorGroup == null) - pipeline.addLast(NettyServerHandler(handlers, null)) - else - pipeline.addLast(executorGroup, NettyServerHandler(handlers, null)) - } - } - - class HttpsChannelInitializer( - private val handlers: Map, - private val sslContext: SslContext, - private val sslSettings: SslSettings, - private val executorGroup: EventExecutorGroup?, - private val settings: HttpServerSettings, - ) : ChannelInitializer() { - - override fun initChannel(channel: SocketChannel) { - val pipeline = channel.pipeline() - val sslHandler = sslContext.newHandler(channel.alloc()) - val handlerSsl = if (sslSettings.clientAuth) sslHandler else null - - pipeline.addLast(sslHandler) - pipeline.addLast(HttpServerCodec()) - pipeline.addLast(HttpServerKeepAliveHandler()) - pipeline.addLast(HttpObjectAggregator(MAX_VALUE)) - pipeline.addLast(ChunkedWriteHandler()) - - if (settings.zip) - pipeline.addLast(HttpContentCompressor()) - - if (executorGroup == null) - pipeline.addLast(NettyServerHandler(handlers, handlerSsl)) - else - pipeline.addLast(executorGroup, NettyServerHandler(handlers, handlerSsl)) - } - } } diff --git a/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyServerHandler.kt b/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyServerHandler.kt index 34d83e46c8..5179fc7fe7 100644 --- a/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyServerHandler.kt +++ b/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyServerHandler.kt @@ -47,10 +47,10 @@ internal class NettyServerHandler( } private fun readHttpRequest(context: ChannelHandlerContext, nettyRequest: HttpRequest) { - val result = nettyRequest.decoderResult() - - if (result.isFailure) - throw IllegalStateException(result.cause()) +// val result = nettyRequest.decoderResult() +// +// if (result.isFailure) +// throw IllegalStateException(result.cause()) val channel = context.channel() val address = channel.remoteAddress() as InetSocketAddress From 72a71d06c2f2b069b9a6e847e1ea76ef6906c7b0 Mon Sep 17 00:00:00 2001 From: jaguililla Date: Sat, 4 Nov 2023 16:14:52 +0100 Subject: [PATCH 3/3] Improve Netty server adapter --- .../api/http_server_netty.api | 6 ++-- .../server/netty/HttpChannelInitializer.kt | 16 ++++++--- .../server/netty/HttpsChannelInitializer.kt | 17 +++++++--- .../http/server/netty/NettyRequestAdapter.kt | 5 ++- .../http/server/netty/NettyServerAdapter.kt | 30 +++++++++++++++-- .../http/server/netty/NettyServerHandler.kt | 33 +++++++++++-------- .../http/server/netty/AdapterExamplesTest.kt | 20 +++++++++++ 7 files changed, 99 insertions(+), 28 deletions(-) diff --git a/http/http_server_netty/api/http_server_netty.api b/http/http_server_netty/api/http_server_netty.api index 7756e9de52..4111d55199 100644 --- a/http/http_server_netty/api/http_server_netty.api +++ b/http/http_server_netty/api/http_server_netty.api @@ -6,7 +6,7 @@ public final class com/hexagonkt/http/server/netty/NettyKt { } public final class com/hexagonkt/http/server/netty/NettyRequestAdapter : com/hexagonkt/http/model/HttpRequestPort { - public fun (Lio/netty/handler/codec/http/HttpMethod;Lio/netty/handler/codec/http/HttpRequest;Ljava/util/List;Ljava/net/InetSocketAddress;Lio/netty/handler/codec/http/HttpHeaders;)V + public fun (Lio/netty/handler/codec/http/HttpMethod;Lio/netty/handler/codec/http/HttpRequest;Ljava/util/List;Lio/netty/channel/Channel;Lio/netty/handler/codec/http/HttpHeaders;)V public fun authorization ()Lcom/hexagonkt/http/model/Authorization; public fun bodyString ()Ljava/lang/String; public fun certificate ()Ljava/security/cert/X509Certificate; @@ -46,8 +46,8 @@ public final class com/hexagonkt/http/server/netty/NettyRequestAdapter : com/hex public class com/hexagonkt/http/server/netty/NettyServerAdapter : com/hexagonkt/http/server/HttpServerPort { public fun ()V - public fun (IIIIZZJJ)V - public synthetic fun (IIIIZZJJILkotlin/jvm/internal/DefaultConstructorMarker;)V + public fun (IIIIZZJJZZZZ)V + public synthetic fun (IIIIZZJJZZZZILkotlin/jvm/internal/DefaultConstructorMarker;)V public fun groupSupplier (I)Lio/netty/channel/MultithreadEventLoopGroup; public fun options ()Ljava/util/Map; public fun runtimePort ()I diff --git a/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/HttpChannelInitializer.kt b/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/HttpChannelInitializer.kt index 5c29512d1f..c933958108 100644 --- a/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/HttpChannelInitializer.kt +++ b/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/HttpChannelInitializer.kt @@ -12,20 +12,28 @@ internal class HttpChannelInitializer( private val handlers: Map, private val executorGroup: EventExecutorGroup?, private val settings: HttpServerSettings, + private val keepAliveHandler: Boolean = true, + private val httpAggregatorHandler: Boolean = true, + private val chunkedHandler: Boolean = true, + private val enableWebsockets: Boolean = true, ) : ChannelInitializer() { override fun initChannel(channel: SocketChannel) { val pipeline = channel.pipeline() pipeline.addLast(HttpServerCodec()) -// pipeline.addLast(HttpServerKeepAliveHandler()) - pipeline.addLast(HttpObjectAggregator(Int.MAX_VALUE)) -// pipeline.addLast(ChunkedWriteHandler()) + if (keepAliveHandler) + pipeline.addLast(HttpServerKeepAliveHandler()) + if (httpAggregatorHandler) + pipeline.addLast(HttpObjectAggregator(Int.MAX_VALUE)) + if (chunkedHandler) + pipeline.addLast(ChunkedWriteHandler()) if (settings.zip) pipeline.addLast(HttpContentCompressor()) - val nettyServerHandler = NettyServerHandler(handlers, null) + val nettyServerHandler = NettyServerHandler(handlers, null, enableWebsockets) + if (executorGroup == null) pipeline.addLast(nettyServerHandler) else diff --git a/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/HttpsChannelInitializer.kt b/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/HttpsChannelInitializer.kt index bdfdcafa96..8005e05400 100644 --- a/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/HttpsChannelInitializer.kt +++ b/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/HttpsChannelInitializer.kt @@ -7,6 +7,7 @@ import io.netty.channel.ChannelInitializer import io.netty.channel.socket.SocketChannel import io.netty.handler.codec.http.* import io.netty.handler.ssl.SslContext +import io.netty.handler.stream.ChunkedWriteHandler import io.netty.util.concurrent.EventExecutorGroup internal class HttpsChannelInitializer( @@ -15,6 +16,10 @@ internal class HttpsChannelInitializer( private val sslSettings: SslSettings, private val executorGroup: EventExecutorGroup?, private val settings: HttpServerSettings, + private val keepAliveHandler: Boolean = true, + private val httpAggregatorHandler: Boolean = true, + private val chunkedHandler: Boolean = true, + private val enableWebsockets: Boolean = true, ) : ChannelInitializer() { override fun initChannel(channel: SocketChannel) { @@ -24,14 +29,18 @@ internal class HttpsChannelInitializer( pipeline.addLast(sslHandler) pipeline.addLast(HttpServerCodec()) -// pipeline.addLast(HttpServerKeepAliveHandler()) - pipeline.addLast(HttpObjectAggregator(Int.MAX_VALUE)) -// pipeline.addLast(ChunkedWriteHandler()) + if (keepAliveHandler) + pipeline.addLast(HttpServerKeepAliveHandler()) + if (httpAggregatorHandler) + pipeline.addLast(HttpObjectAggregator(Int.MAX_VALUE)) + if (chunkedHandler) + pipeline.addLast(ChunkedWriteHandler()) if (settings.zip) pipeline.addLast(HttpContentCompressor()) - val serverHandler = NettyServerHandler(handlers, handlerSsl) + val serverHandler = NettyServerHandler(handlers, handlerSsl, enableWebsockets) + if (executorGroup == null) pipeline.addLast(serverHandler) else diff --git a/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyRequestAdapter.kt b/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyRequestAdapter.kt index d344d57a02..260af5a8df 100644 --- a/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyRequestAdapter.kt +++ b/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyRequestAdapter.kt @@ -7,6 +7,7 @@ import com.hexagonkt.http.parseContentType import io.netty.buffer.ByteBufHolder import io.netty.buffer.ByteBufUtil import io.netty.buffer.Unpooled +import io.netty.channel.Channel import io.netty.handler.codec.http.HttpHeaderNames.* import io.netty.handler.codec.http.HttpHeaders import io.netty.handler.codec.http.QueryStringDecoder @@ -26,10 +27,12 @@ class NettyRequestAdapter( methodName: NettyHttpMethod, req: HttpRequest, override val certificateChain: List, - address: InetSocketAddress, + channel: Channel, nettyHeaders: HttpHeaders, ) : HttpRequestPort { + private val address: InetSocketAddress by lazy { channel.remoteAddress() as InetSocketAddress } + override val accept: List by lazy { nettyHeaders.getAll(ACCEPT).flatMap { it.split(",") }.map { parseContentType(it) } } diff --git a/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyServerAdapter.kt b/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyServerAdapter.kt index c89144bde4..8d92084738 100644 --- a/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyServerAdapter.kt +++ b/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyServerAdapter.kt @@ -39,6 +39,10 @@ open class NettyServerAdapter( private val soKeepAlive: Boolean = true, private val shutdownQuietSeconds: Long = 0, private val shutdownTimeoutSeconds: Long = 0, + private val keepAliveHandler: Boolean = true, + private val httpAggregatorHandler: Boolean = true, + private val chunkedHandler: Boolean = true, + private val enableWebsockets: Boolean = true, ) : HttpServerPort { private var nettyChannel: Channel? = null @@ -120,7 +124,15 @@ open class NettyServerAdapter( ) = when { sslSettings != null -> sslInitializer(sslSettings, handlers, group, settings) - else -> HttpChannelInitializer(handlers, group, settings) + else -> HttpChannelInitializer( + handlers, + group, + settings, + keepAliveHandler, + httpAggregatorHandler, + chunkedHandler, + enableWebsockets, + ) } private fun sslInitializer( @@ -129,7 +141,17 @@ open class NettyServerAdapter( group: DefaultEventExecutorGroup?, settings: HttpServerSettings ): HttpsChannelInitializer = - HttpsChannelInitializer(handlers, sslContext(sslSettings), sslSettings, group, settings) + HttpsChannelInitializer( + handlers, + sslContext(sslSettings), + sslSettings, + group, + settings, + keepAliveHandler, + httpAggregatorHandler, + chunkedHandler, + enableWebsockets, + ) private fun sslContext(sslSettings: SslSettings): SslContext { val keyManager = createKeyManagerFactory(sslSettings) @@ -191,5 +213,9 @@ open class NettyServerAdapter( NettyServerAdapter::soKeepAlive to soKeepAlive, NettyServerAdapter::shutdownQuietSeconds to shutdownQuietSeconds, NettyServerAdapter::shutdownTimeoutSeconds to shutdownTimeoutSeconds, + NettyServerAdapter::keepAliveHandler to keepAliveHandler, + NettyServerAdapter::httpAggregatorHandler to httpAggregatorHandler, + NettyServerAdapter::chunkedHandler to chunkedHandler, + NettyServerAdapter::enableWebsockets to enableWebsockets, ) } diff --git a/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyServerHandler.kt b/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyServerHandler.kt index 5179fc7fe7..26583b8518 100644 --- a/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyServerHandler.kt +++ b/http/http_server_netty/src/main/kotlin/com/hexagonkt/http/server/netty/NettyServerHandler.kt @@ -29,7 +29,6 @@ import io.netty.handler.codec.http.cookie.ServerCookieEncoder.STRICT as STRICT_E import io.netty.handler.codec.http.websocketx.WebSocketServerHandshakerFactory import io.netty.handler.ssl.SslHandler import io.netty.handler.ssl.SslHandshakeCompletionEvent -import java.net.InetSocketAddress import java.security.cert.X509Certificate import java.util.concurrent.Flow.* import com.hexagonkt.http.model.HttpRequest as HexagonHttpRequest @@ -37,6 +36,7 @@ import com.hexagonkt.http.model.HttpRequest as HexagonHttpRequest internal class NettyServerHandler( private val handlers: Map, private val sslHandler: SslHandler?, + private val enableWebsockets: Boolean = true, ) : ChannelInboundHandlerAdapter() { private var certificates: List = emptyList() @@ -47,18 +47,17 @@ internal class NettyServerHandler( } private fun readHttpRequest(context: ChannelHandlerContext, nettyRequest: HttpRequest) { -// val result = nettyRequest.decoderResult() -// -// if (result.isFailure) -// throw IllegalStateException(result.cause()) + val result = nettyRequest.decoderResult() + + if (result.isFailure) + throw IllegalStateException(result.cause()) val channel = context.channel() - val address = channel.remoteAddress() as InetSocketAddress val method = nettyRequest.method() val pathHandler = handlers[method] val headers = nettyRequest.headers() - val request = NettyRequestAdapter(method, nettyRequest, certificates, address, headers) + val request = NettyRequestAdapter(method, nettyRequest, certificates, channel, headers) if (pathHandler == null) { writeResponse(context, request, HttpResponse(), HttpUtil.isKeepAlive(nettyRequest)) @@ -68,15 +67,12 @@ internal class NettyServerHandler( val resultContext = pathHandler.process(request) val response = resultContext.event.response - val body = response.body - val connection = headers[CONNECTION]?.lowercase() - val upgrade = headers[UPGRADE]?.lowercase() + val isWebSocket = + if (enableWebsockets) isWebsocket(headers, method, response.status) + else false + val body = response.body val isSse = body is Publisher<*> - val isWebSocket = connection == "upgrade" - && upgrade == "websocket" - && method == GET - && response.status == ACCEPTED_202 when { isSse -> handleSse(context, request, response, body) @@ -85,6 +81,15 @@ internal class NettyServerHandler( } } + private fun isWebsocket(headers: HttpHeaders, method: HttpMethod, status: HttpStatus): Boolean { + val connection = headers[CONNECTION]?.lowercase() + val upgrade = headers[UPGRADE]?.lowercase() + return connection == "upgrade" + && upgrade == "websocket" + && method == GET + && status == ACCEPTED_202 + } + @Suppress("UNCHECKED_CAST") // Body not cast to Publisher due to type erasure private fun handleSse( context: ChannelHandlerContext, diff --git a/http/http_server_netty/src/test/kotlin/com/hexagonkt/http/server/netty/AdapterExamplesTest.kt b/http/http_server_netty/src/test/kotlin/com/hexagonkt/http/server/netty/AdapterExamplesTest.kt index a63dee8370..2d438f09b6 100644 --- a/http/http_server_netty/src/test/kotlin/com/hexagonkt/http/server/netty/AdapterExamplesTest.kt +++ b/http/http_server_netty/src/test/kotlin/com/hexagonkt/http/server/netty/AdapterExamplesTest.kt @@ -31,3 +31,23 @@ internal class AdapterBenchmarkIT : BenchmarkIT(clientAdapter, serverAdapter) internal class AdapterSseTest : SseTest(clientAdapter, serverAdapter) @DisabledInNativeImage // TODO Fix this internal class AdapterWebSocketsTest : WebSocketsTest(clientAdapter, serverAdapter) + +val liteServerAdapter: () -> NettyServerAdapter = { + NettyServerAdapter( + keepAliveHandler = false, + httpAggregatorHandler = false, + chunkedHandler = false, + enableWebsockets = false, + ) +} + +internal class LiteAdapterBooksTest : BooksTest(clientAdapter, liteServerAdapter) +internal class LiteAdapterErrorsTest : ErrorsTest(clientAdapter, liteServerAdapter) +internal class LiteAdapterFiltersTest : FiltersTest(clientAdapter, liteServerAdapter) +@DisabledOnOs(WINDOWS) // TODO Make this work on GitHub runners +internal class LiteAdapterHttpsTest : HttpsTest(clientAdapter, liteServerAdapter) +internal class LiteAdapterZipTest : ZipTest(clientAdapter, liteServerAdapter) +internal class LiteAdapterCookiesTest : CookiesTest(clientAdapter, liteServerAdapter) +internal class LiteAdapterCorsTest : CorsTest(clientAdapter, liteServerAdapter) +internal class LiteAdapterBenchmarkIT : BenchmarkIT(clientAdapter, liteServerAdapter) +internal class LiteAdapterSseTest : SseTest(clientAdapter, liteServerAdapter)