merge: pull in the fallow-audit fixes

Author: vanceingalls

.fallowrc.jsonc

@@ -654,6 +654,28 @@
       // inherited clone; consistent with the norm above of leaving parallel
       // command-test cases unabstracted.
       "packages/cli/src/commands/check.test.ts",
+      // canary.test.ts: rawFnv is a deliberate independent re-implementation of
+      // canary.ts's fnv1a32, not copy-paste — its own docstring explains why:
+      // the test re-derives the hash so it can cross-check canaryBucket against
+      // a copy that owes it nothing, rather than importing the function under
+      // test. Importing fnv1a32 here would defeat the point of the assertion.
+      "packages/core/src/canary.test.ts",
+      // The audio FX property-panel test files (and the two siblings outside
+      // this stack, propertyPanelFlatMotionSection.test.tsx and
+      // propertyPanelFlatEffectsSection.test.tsx) share a `renderInto` React
+      // mount helper — pre-existing across nine files, not introduced here.
+      // The FxSection/FlatTextSection `mount()` wrappers additionally look
+      // alike because both build a props-with-overrides harness for their own
+      // component; the prop shapes differ per component, so a shared mount
+      // abstraction would obscure more than it dedupes (same rationale as
+      // slideshowPanelHelpers.ts above).
+      "packages/studio/src/components/editor/PropertyPanelEmptyState.test.tsx",
+      "packages/studio/src/components/editor/propertyPanelFlatColorGradingSection.test.tsx",
+      "packages/studio/src/components/editor/propertyPanelFlatLayoutSection.test.tsx",
+      "packages/studio/src/components/editor/propertyPanelFlatPrimitives.test.tsx",
+      "packages/studio/src/components/editor/propertyPanelFlatTextSection.test.tsx",
+      "packages/studio/src/components/editor/propertyPanelFlatToggle.test.tsx",
+      "packages/studio/src/components/editor/propertyPanelFxSection.test.tsx",
     ],
   },
   "health": {

packages/core/package.json

@@ -556,9 +556,9 @@
     "typecheck": "tsc --noEmit && bun run typecheck:runtime",
     "typecheck:runtime": "tsc --noEmit -p tsconfig.runtime.json",
     "lint:runtime-preview-guards": "bun scripts/lint-runtime-preview-guards.ts",
-    "build:audio-fx-runtime": "tsx scripts/build-audio-fx-runtime.ts",
+    "build:audio-fx-runtime": "tsx scripts/build-inline-artifact.ts audio-fx",
     "build:hyperframes-runtime": "tsx scripts/build-hyperframes-runtime-artifact.ts",
-    "build:position-edits-render": "tsx scripts/build-position-edits-render.ts",
+    "build:position-edits-render": "tsx scripts/build-inline-artifact.ts position-edits",
     "check:position-edits-render": "bun run build:position-edits-render && git diff --exit-code -- src/generated/position-edits-render-inline.ts",
     "build:hyperframes-runtime:modular": "SANDBOX_RUNTIME_VARIANT=modular tsx scripts/build-hyperframes-runtime-artifact.ts",
     "build:hyperframe-runtime": "tsx scripts/build-hyperframes-runtime-artifact.ts",

packages/core/scripts/build-audio-fx-runtime.ts

@@ -0,0 +1,97 @@
+/**
+ * Bundle one canonical-runtime entry to a minified IIFE with esbuild and write
+ * it into `src/generated` as a string constant behind a getter.
+ *
+ * One script handles both inline artifacts — the audio-FX runtime and the
+ * position-edits render — since they differ only in the entry, output names,
+ * and log event. Keeping them as separate files produced a byte-for-byte
+ * clone that fallow kept re-flagging on every unrelated line shift.
+ */
+
+import { mkdirSync, writeFileSync } from "node:fs";
+import { dirname, resolve } from "node:path";
+import { fileURLToPath } from "node:url";
+import { buildSync } from "esbuild";
+import { execFileSync } from "node:child_process";
+
+interface InlineArtifactTarget {
+  entryRelPath: string;
+  generatedFileName: string;
+  constName: string;
+  getterName: string;
+  /** Filename shown in the esbuild-failure error. */
+  entryLabel: string;
+  /** Human phrase for the generated getter's doc comment, e.g. "audio-FX runtime". */
+  docLabel: string;
+  event: string;
+}
+
+const TARGETS: Record<string, InlineArtifactTarget> = {
+  "audio-fx": {
+    entryRelPath: "stubs/audio-fx-runtime-entry.ts",
+    generatedFileName: "audio-fx-runtime-inline.ts",
+    constName: "AUDIO_FX_RUNTIME_IIFE",
+    getterName: "getAudioFxRuntimeScript",
+    entryLabel: "audio-fx-runtime-entry.ts",
+    docLabel: "audio-FX runtime",
+    event: "audio_fx_runtime_generated",
+  },
+  "position-edits": {
+    entryRelPath: "stubs/position-edits-render-entry.ts",
+    generatedFileName: "position-edits-render-inline.ts",
+    constName: "POSITION_EDITS_RENDER_IIFE",
+    getterName: "getPositionEditsRenderScript",
+    entryLabel: "position-edits-render-entry.ts",
+    docLabel: "position-edits render",
+    event: "position_edits_render_generated",
+  },
+};
+
+const key = process.argv[2] ?? "";
+const target = TARGETS[key];
+if (!target) {
+  throw new Error(`Usage: build-inline-artifact.ts <${Object.keys(TARGETS).join("|")}>`);
+}
+
+const thisDir = dirname(fileURLToPath(import.meta.url));
+const repoRoot = resolve(thisDir, "..");
+const entry = resolve(repoRoot, target.entryRelPath);
+const generatedDir = resolve(repoRoot, "src/generated");
+const outPath = resolve(generatedDir, target.generatedFileName);
+
+const result = buildSync({
+  entryPoints: [entry],
+  bundle: true,
+  write: false,
+  platform: "browser",
+  format: "iife",
+  target: ["es2020"],
+  minify: true,
+  legalComments: "none",
+});
+const iife = result.outputFiles[0]?.text ?? "";
+if (!iife) throw new Error(`esbuild produced no output for ${target.entryLabel}`);
+
+mkdirSync(generatedDir, { recursive: true });
+writeFileSync(
+  outPath,
+  [
+    "// AUTO-GENERATED by scripts/build-inline-artifact.ts - do not edit",
+    `const ${target.constName}: string = ${JSON.stringify(iife)};`,
+    "",
+    `/** Returns the pre-built ${target.docLabel} IIFE as a string constant. */`,
+    `export function ${target.getterName}(): string {`,
+    `  return ${target.constName};`,
+    "}",
+    "",
+  ].join("\n"),
+  "utf8",
+);
+
+try {
+  execFileSync("bun", ["x", "oxfmt", outPath], { stdio: "ignore" });
+} catch {
+  // Formatting is best effort when the generator runs in a minimal environment.
+}
+
+console.log(JSON.stringify({ event: target.event, outPath, bytes: iife.length }));

packages/core/scripts/build-inline-artifact.ts

@@ -1,4 +1,4 @@
-// AUTO-GENERATED by scripts/build-position-edits-render.ts - do not edit
+// AUTO-GENERATED by scripts/build-inline-artifact.ts - do not edit
 const POSITION_EDITS_RENDER_IIFE: string =
   '"use strict";(()=>{function A(){return globalThis}function P(e,t){if(typeof window>"u")return;let n=A(),r=n.__hf?.onSwallowed;if(r)try{r({label:e,error:t})}catch(i){}(n.__hfDebug||n.__HYPERFRAMES_DEBUG)&&console.debug(`[hyperframes] ${e} swallowed:`,t)}var T=null;function R(e,t){if(T)try{T({source:"hf-preview",type:"analytics",event:e,properties:t??{}})}catch(n){P("runtime.analytics.site1",n)}}var w="data-hf-edit-base-x",k="data-hf-edit-base-y",y="data-hf-edit-original-translate",S=e=>{let t=parseFloat(e??"");return Number.isFinite(t)?t:0},V=e=>{let t=[],n=0,r="";for(let i of e.trim())i==="("&&(n+=1),i===")"&&(n=Math.max(0,n-1)),/\\s/.test(i)&&n===0?(r&&t.push(r),r=""):r+=i;return r&&t.push(r),t},$=/^-?(?:\\d+(?:\\.\\d+)?|\\.\\d+)px$/,E=(e,t)=>$.test(e)&&$.test(t)?`${parseFloat(e)+parseFloat(t)}px`:`calc(${e} + ${t})`,I=(e,t,n)=>{if(!e||e==="none")return`${t} ${n}`;let[r,i,u]=V(e);if(r===void 0)return`${t} ${n}`;if(i===void 0)return`${E(r,t)} ${n}`;let d=u===void 0?"":` ${u}`;return`${E(r,t)} ${E(i,n)}${d}`},O=e=>{try{e.ownerDocument.defaultView?.gsap?.getProperty?.(e,"x")}catch{}},G=e=>{let t=e.style.getPropertyValue("translate").trim();if(t)return t==="none"?"":t;try{let n=e.ownerDocument.defaultView,r=n?n.getComputedStyle(e).getPropertyValue("translate").trim():"";return r==="none"?"":r}catch{return""}},h=new WeakMap;function H(e,t){let n=h.get(e);if(!t?.force&&n!==void 0&&e.style.getPropertyValue("translate")!==n){R("position_edit_fold_skipped",{hfId:e.getAttribute("data-hf-id")});return}let r=S(e.getAttribute("data-x"))-S(e.getAttribute(w)),i=S(e.getAttribute("data-y"))-S(e.getAttribute(k));e.hasAttribute(y)||e.setAttribute(y,G(e)),n===void 0&&O(e);let u=e.getAttribute(y)??"",d=I(u,`${r}px`,`${i}px`);e.style.setProperty("translate",d),h.set(e,e.style.getPropertyValue("translate"))}function v(e,t){let n=e.defaultView?.HTMLElement,r=e.defaultView?.SVGElement,i=a=>n||r?n!==void 0&&a instanceof n||r!==void 0&&a instanceof r:typeof a.style?.setProperty=="function",u=e.querySelectorAll(`[${y}]:not([${w}]):not([${k}])`);for(let a=0;a<u.length;a++){let l=u[a];if(l===void 0||!i(l))continue;let b=l.getAttribute(y)??"";b===""?l.style.removeProperty("translate"):l.style.setProperty("translate",b),l.removeAttribute(y),h.delete(l)}let d=e.querySelectorAll(`[${w}], [${k}]`),m=0;for(let a=0;a<d.length;a++){let l=d[a];l===void 0||!i(l)||(H(l,t),m+=1)}return m}var x="__hfPositionEditsSeekReapplyWrapped",D=new WeakSet,F=new WeakMap,W=new WeakMap;function L(e){let t=e,n=()=>{try{v(t.document)}catch{}},r=o=>typeof o=="function"&&(D.has(o)||!!o[x]),i=o=>{D.add(o);try{Object.defineProperty(o,x,{value:!0})}catch{}},u=o=>{if(typeof o!="function"||r(o))return o;let s=function(...c){let f=o.apply(this,c);return n(),f};return i(s),s},d=(o,s)=>{let c=F.get(o);if(c?.has(s))return!0;let f=Object.getOwnPropertyDescriptor(o,s);if(f?.configurable===!1){let p=o[s];return typeof p=="function"&&(o[s]=u(p),n()),!1}let g=o[s],_=f?.set;return Object.defineProperty(o,s,{configurable:!0,enumerable:f?.enumerable??!0,get:()=>g,set:p=>{g=u(p),_?.call(o,p)}}),g=u(g),c??(c=new Set),c.add(s),F.set(o,c),n(),!0},m=(o,s)=>{let c=W.get(t),f=Object.getOwnPropertyDescriptor(t,o);if(!c?.has(o)){if(f?.configurable===!1){let p=t[o];return p?d(p,s):!1}let _=t[o];Object.defineProperty(t,o,{configurable:!0,enumerable:f?.enumerable??!0,get:()=>_,set:p=>{_=p,_&&d(_,s)}}),c??(c=new Set),c.add(o),W.set(t,c)}let g=t[o];return g?d(g,s):!1},a=()=>{let o=m("__hf","seek"),s=m("__player","renderSeek");return o&&s};if(a())return;let l=120,b=t.setInterval(()=>{if(a()){t.clearInterval(b);return}l-=1,l<=0&&t.clearInterval(b)},50)}function M(){document.querySelector(`[${w}], [${k}]`)&&(v(document),L(window))}document.readyState==="loading"?document.addEventListener("DOMContentLoaded",M,{once:!0}):M();})();\n';
 

packages/core/scripts/build-position-edits-render.ts

@@ -59,6 +59,11 @@ const click = (el: Element | null | undefined) => {
 const byText = (host: HTMLElement, sel: string, text: string) =>
   Array.from(host.querySelectorAll(sel)).find((e) => e.textContent?.trim() === text);
 
+const openAddMenuItems = (host: HTMLElement) => {
+  click(host.querySelector(".hf-fx-add"));
+  return Array.from(host.querySelectorAll(".hf-fx-add-item")).map((e) => e.textContent?.trim());
+};
+
 /**
  * React tracks an input's value on the DOM node, so assigning `.value` and
  * dispatching looks like a no-op change and the handler never fires. Going
@@ -87,10 +92,7 @@ describe("FxSection chain", () => {
     // The add menu is generated, so a new effect upstream appears here with no
     // change to the panel.
     const { host } = mount();
-    click(host.querySelector(".hf-fx-add"));
-    const items = Array.from(host.querySelectorAll(".hf-fx-add-item")).map((e) =>
-      e.textContent?.trim(),
-    );
+    const items = openAddMenuItems(host);
     expect(items).toHaveLength(HF_AUDIO_FX.length);
     for (const def of HF_AUDIO_FX) expect(items).toContain(def.label);
   });
@@ -199,10 +201,7 @@ describe("FxSection carve", () => {
   it("is off by default and is not an entry in the chain", () => {
     const { host } = mount();
     expect(host.querySelector(".hf-fx-carve")).toBeTruthy();
-    click(host.querySelector(".hf-fx-add"));
-    const items = Array.from(host.querySelectorAll(".hf-fx-add-item")).map((e) =>
-      e.textContent?.trim(),
-    );
+    const items = openAddMenuItems(host);
     expect(items).not.toContain("Voiceover carve");
   });