Skip to content

Commit 113f9ea

Browse files
authored
ci: subscribe to edited PR events so workflows re-fire after Graphite restacks (#429)
## What Brief description of the change. ## Why Why is this change needed? ## How How was this implemented? Any notable design decisions? ## Test plan How was this tested? - [ ] Unit tests added/updated - [ ] Manual testing performed - [ ] Documentation updated (if applicable)
1 parent 9512744 commit 113f9ea

2 files changed

Lines changed: 12 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@ name: CI
22

33
on:
44
pull_request:
5+
# `edited` is required so the workflow re-fires when a PR's base ref is
6+
# set back to `main` after a Graphite stack restack momentarily flips
7+
# the base off of `main`. Without it, `pull_request` triggers are not
8+
# re-evaluated on `base_ref_changed`, leaving required checks skipped
9+
# for that head SHA forever.
10+
types: [opened, synchronize, reopened, edited]
511
branches: [main]
612
push:
713
branches: [main]

.github/workflows/windows-render.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@ name: Windows render verification
88

99
on:
1010
pull_request:
11+
# `edited` is required so the workflow re-fires when a PR's base ref is
12+
# set back to `main` after a Graphite stack restack momentarily flips
13+
# the base off of `main`. Without it, `pull_request` triggers are not
14+
# re-evaluated on `base_ref_changed`, leaving required checks skipped
15+
# for that head SHA forever.
16+
types: [opened, synchronize, reopened, edited]
1117
branches: [main]
1218
push:
1319
branches: [main]

0 commit comments

Comments
 (0)