Skip to content

Commit 1b7e265

Browse files
vanceingallsvanceingalls
committed
fix(player): defer preconnect option reloads
1 parent 33e302d commit 1b7e265

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

‎packages/player/src/hyperframes-player.test.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1499,8 +1499,11 @@ describe("HyperframesPlayer srcdoc attribute", () => {
14991499

15001500
it("uses a configured runtime source for loopback srcdoc", () => {
15011501
const player = document.createElement("hyperframes-player") as PlayerInternal;
1502-
player.setAttribute("runtime-src", "http://127.0.0.1:8900/hyperframe.runtime.iife.js");
15031502
player.setAttribute("srcdoc", "<!doctype html><html><head></head><body></body></html>");
1503+
player.setAttribute("runtime-src", "http://127.0.0.1:8900/hyperframe.runtime.iife.js");
1504+
1505+
expect(player.iframe.hasAttribute("srcdoc")).toBe(false);
1506+
15041507
document.body.appendChild(player);
15051508

15061509
expect(player.iframe.getAttribute("srcdoc")).toContain(

‎packages/player/src/hyperframes-player.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,7 @@ class HyperframesPlayer extends HTMLElement {
300300
case SHADER_CAPTURE_SCALE_ATTR:
301301
case SHADER_LOADING_ATTR:
302302
case RUNTIME_SRC_ATTR:
303+
if (!this.isConnected) break;
303304
this._reloadShaderOptions();
304305
break;
305306
}

0 commit comments

Comments
 (0)