Skip to content

Commit 239331f

Browse files
committed
ci: drop the stray version echo left in the player-perf ffmpeg step
Converting the step to the shared action left the trailing `ffmpeg -version` line behind, and YAML folded it into the `uses:` value — so the runner looked for an action at a path with the command appended and failed all four perf shards. It parsed cleanly, which is why validating with a YAML load did not catch it: `uses: ./path\n ffmpeg -version` is a legal folded scalar. The check that does catch it asserts every local `uses:` resolves to a directory containing an action file, which is now what I ran. The action prints the version itself.
1 parent 91b2dfe commit 239331f

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

.github/workflows/player-perf.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,6 @@ jobs:
106106
- name: Install ffmpeg (parity shard only)
107107
if: matrix.shard == 'parity'
108108
uses: ./.github/actions/install-ffmpeg-linux
109-
ffmpeg -version | head -n 1
110109

111110
- name: Run player perf — ${{ matrix.shard }} (measure mode)
112111
working-directory: packages/player

0 commit comments

Comments
 (0)