fix(studio): classify stale delete previews

Author: miguel-heygen

packages/studio/src/hooks/domEditCommitRunner.ts

@@ -72,6 +72,7 @@ export type DomEditCommitDeclineReason =
   | "geometry-property"
   | "styles-not-editable"
   | "not-text-editable"
+  | "preview-stale"
   | "persist-failed";
 
 export type DomEditCommitOutcome = { ok: true } | { ok: false; reason: DomEditCommitDeclineReason };

packages/studio/src/hooks/useElementLifecycleOps.multiDelete.test.tsx

@@ -145,6 +145,6 @@ describe("useElementLifecycleOps — deleting a canvas multi-selection", () => {
     });
 
     expect(showToast.mock.calls.flat().join(" ")).toContain("out of date");
-    expect(outcome).toEqual({ ok: false, reason: "persist-failed" });
+    expect(outcome).toEqual({ ok: false, reason: "preview-stale" });
   });
 });

packages/studio/src/hooks/useElementLifecycleOps.ts

@@ -175,7 +175,8 @@ export function useElementLifecycleOps({
           // matching at all means the preview is describing a document the file
           // does not have — say so rather than reporting a delete that happened.
           reloadPreview();
-          throw new Error("Nothing to delete — the preview was out of date. Try again.");
+          showToast("Nothing to delete, the preview was out of date. Try again.");
+          return domEditCommitDeclined("preview-stale");
         }
         const patchedContent =
           typeof removeData.content === "string" ? removeData.content : originalContent;