Skip to content

Commit 36bddd2

Browse files
committed
docs(plans): record the rack wiring and what it cost
1 parent e4e0365 commit 36bddd2

1 file changed

Lines changed: 18 additions & 6 deletions

File tree

plans/audio-fx-ux/README.md

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -194,12 +194,24 @@ layer has now landed as `packages/core/src/audioFxCopy.ts` — `EFFECT_COPY`,
194194
`BANDS`, `PRESET_PROBLEM` and `SUMMARY`, with the completeness check as a test
195195
beside it rather than a build step.
196196

197-
Landing the data is not the same as wiring it, and **nothing in the studio reads
198-
it yet**. That was blocked on the naming question until 2026-08-10; it is now
199-
just unbuilt. What it takes: `propertyPanelFxNodeRow.tsx` reads `EFFECT_COPY`
200-
for the header and `SUMMARY` for the collapsed line, `propertyPanelFxSection`'s
201-
preset menu groups by `PRESET_PROBLEM`, and the hover-audition path is new work
202-
of its own.
197+
**It is wired.** `propertyPanelFxNodeRow.tsx` takes the name from `EFFECT_COPY`,
198+
the sentence under it from `SUMMARY`, and every knob's name from the same place
199+
via `plainDef` — which writes the words over the registry's def and leaves range,
200+
step, unit and automatability alone. The DSP name sits above the knobs as
201+
`Details — High-pass`. The preset shelf leads with `PRESET_PROBLEM` and follows
202+
with the preset's own name. Hover and focus both audition, through the same
203+
preview channel a slider drag uses; the leveller measures first, says
204+
"measuring…" while it does, caches the decode per `src`, and drops a result that
205+
arrives after the pointer has gone.
206+
207+
Three things that took a second pass, all worth knowing before touching this
208+
again. An audition has to survive the panel re-rendering under it — the group
209+
re-renders every playhead tick, so anything keyed on its inline callbacks tears
210+
down thirty times a second. Applying must NOT revert, since the audition *was*
211+
the thing applied. And moving between two entries in a shelf is not leaving it,
212+
so each entry has to call its neighbours' auditions off itself.
213+
214+
What is still not wired: `PROFILES`, below.
203215

204216
It has no entry for Tone or for the levelling module, because both carry their
205217
own copy in core (`audioEqSummary`, `levellingSummary`). That is the right home

0 commit comments

Comments
 (0)