Commit 7b28267
fix(check): key content_overlap collapse by pair, not text
`staticIssueKey` put `issue.text` in the collapse key, but `overlapIssue`
already names a collision by both of its selectors. When the leading element's
text changes per sample — a count-up, typewriter, or rotating word — every
dense-pass sample formed its own group with `occurrences: 1`, so
`applyPersistenceTier` demoted all of them to `info` and a genuinely held
collision never reached the `error` tier that gates a run.
Empirically: two projects with identical geometry and an identical 5.9s
overlap, differing only in DOM order, verdicted differently — label-first gave
`error`/`ok=false`, count-up-first gave 48x `info`/`ok=true`. After this change
both give `error`/`ok=false` with `occurrences: 48`. Seven other overlap
fixtures (crossfades, static, masked reel, 600ms transient) are unchanged.
Codes that identify themselves by text keep it; only `content_overlap`, which
carries both selectors, drops it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent 8c50770 commit 7b28267
2 files changed
Lines changed: 43 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
255 | 255 | | |
256 | 256 | | |
257 | 257 | | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
258 | 294 | | |
259 | 295 | | |
260 | 296 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
342 | 342 | | |
343 | 343 | | |
344 | 344 | | |
345 | | - | |
| 345 | + | |
346 | 346 | | |
347 | 347 | | |
348 | 348 | | |
349 | 349 | | |
350 | 350 | | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
351 | 357 | | |
352 | 358 | | |
353 | 359 | | |
| |||
0 commit comments