Skip to content

Commit 7d9718d

Browse files
committed
fix(cli): narrow blocked page titles
1 parent fad0744 commit 7d9718d

2 files changed

Lines changed: 22 additions & 2 deletions

File tree

packages/cli/src/capture/pageBlockDetection.test.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,26 @@ describe("detectBlockedPage", () => {
7070
hasChallengeElement: true,
7171
},
7272
},
73+
{
74+
label: "a minimal photography page named Forbidden Fruit Photography",
75+
evidence: {
76+
httpStatus: 200,
77+
title: "Forbidden Fruit Photography",
78+
textLength: 40,
79+
bodyChildCount: 4,
80+
hasChallengeElement: false,
81+
},
82+
},
83+
{
84+
label: "a minimal photo essay named Attention Required",
85+
evidence: {
86+
httpStatus: 200,
87+
title: "Attention Required: A Photo Essay",
88+
textLength: 60,
89+
bodyChildCount: 5,
90+
hasChallengeElement: false,
91+
},
92+
},
7393
])("allows $label", ({ evidence }) => {
7494
expect(detectBlockedPage(evidence)).toBeUndefined();
7595
});

packages/cli/src/capture/pageBlockDetection.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ export function detectBlockedPage(evidence: PageLoadEvidence): string | undefine
1616
const hasBlockedStatus =
1717
evidence.httpStatus === 401 || evidence.httpStatus === 403 || evidence.httpStatus === 429;
1818
const hasBlockedTitle =
19-
/^(?:error\s*)?(?:401|403|429)(?:\s*[-:]\s*|\s+)|forbidden|access denied|attention required|just a moment/i.test(
20-
evidence.title,
19+
/^(?:(?:error\s*)?(?:401|403|429)(?:\s*(?:[-:]\s*)?(?:forbidden|unauthorized|access denied|too many requests))?|forbidden|access denied|attention required|just a moment(?:\.{3})?)(?:\s*[|-]\s*(?:cloudflare|sucuri website firewall))?$/i.test(
20+
evidence.title.trim(),
2121
);
2222

2323
if (!isMinimalDom || (!evidence.hasChallengeElement && !hasBlockedStatus && !hasBlockedTitle)) {

0 commit comments

Comments
 (0)