Skip to content

Commit 950209e

Browse files
committed
docs(plans): the profiles shipped; record the stack
1 parent d6429c4 commit 950209e

1 file changed

Lines changed: 18 additions & 10 deletions

File tree

plans/audio-fx-ux/README.md

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@ The plain-language layer over every effect in the registry now ships as
99
`packages/core/src/audioFxCopy.ts`, with the coverage that used to gate this
1010
page — every effect, parameter and preset must have copy — as
1111
`audioFxCopy.test.ts`. `build-preview.mts` renders the review page from it
12-
**plus the real registry and preset catalogue**. Only `PROFILES` is still a
13-
proposal, and it is all that is left in `copy.mts`.
12+
**plus the real registry and preset catalogue**, including the shipped one-knob
13+
profiles — sampled off their real curves, so the page cannot disagree with what
14+
the knob does.
1415

1516
```bash
1617
bun plans/audio-fx-ux/build-preview.mts /tmp/rack-ux.html
@@ -219,8 +220,10 @@ so each entry has to call its neighbours' auditions off itself.
219220
also where the DSP name lives. Ten of fifteen effects; the five whose primary
220221
is "strength" open on all their controls until `PROFILES` ships, which is
221222
honest — inventing one knob for them now would be a knob that lies.
222-
- *One knob that matters.* Half of it. The derived control is `PROFILES` and has
223-
not shipped; what HAS is the case that made the rule incoherent — see below.
223+
- *One knob that matters.* `packages/core/src/audioFxProfiles.ts`. Five effects
224+
get a derived control over several parameters, continuous rather than the
225+
three-point tables proposed here. **Three of the five figures were wrong** and
226+
only rendering showed it — the write-up is `~/audio-fx-profiles-ab/README.md`.
224227
- *Name the outcome.* Modules, knobs, the add menu and the preset shelf.
225228

226229
- **The range IS the module.** The add menu offers five named jobs — Tame
@@ -238,15 +241,20 @@ so each entry has to call its neighbours' auditions off itself.
238241
numbered over what the rack shows, and a preset's consecutive nodes bracketed
239242
as the one thing that was added.
240243

241-
What is still not wired: `PROFILES`, below.
244+
Everything in this document is now built.
242245

243246
It has no entry for Tone or for the levelling module, because both carry their
244247
own copy in core (`audioEqSummary`, `levellingSummary`). That is the right home
245248
for it: a summary that has to read the chain belongs beside the code that
246249
writes it.
247250

248-
The `PROFILES` figures — what one knob derives at gentle/middle/strong — are
249-
**still proposed values, not measured ones**, which is why they stayed behind in
250-
`copy.mts` rather than going to core with the rest. They want the same
251-
before/after listen the clip-before-duck fix got before a knob is wired to
252-
them.
251+
The `PROFILES` figures — what one knob derives at gentle/middle/strong — have
252+
**shipped and been corrected**. They are `HF_AUDIO_FX_PROFILES` in
253+
`packages/core/src/audioFxProfiles.ts`, continuous rather than three-point, and
254+
three of the five were wrong as proposed: the compressor's make-up left the
255+
track quieter at full evenness, saturation's trim went the wrong way and made
256+
"Warmth" mean "much quieter", and the gate did essentially nothing because
257+
`release` was not in the profile at all. Measurements, method and the sweep that
258+
found the last one are in `~/audio-fx-profiles-ab/README.md`.
259+
260+
The stub that used to hold them, `plans/audio-fx-ux/copy.mts`, is gone.

0 commit comments

Comments
 (0)