Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absorb uniqName in uniqCond #115

Open
hgiesel opened this issue Dec 5, 2019 · 1 comment
Open

Absorb uniqName in uniqCond #115

hgiesel opened this issue Dec 5, 2019 · 1 comment

Comments

@hgiesel
Copy link
Owner

hgiesel commented Dec 5, 2019

Biggest drawback is that generators cannot longer drop items after not being successful.
There needs to be some communication between the validator and the generator:

  • if the validation failed because of a uniqueness constraint: drop, otherwise, keep.
@hgiesel hgiesel changed the title Absorb uniqName to uniqCond Absorb uniqName in uniqCond Dec 5, 2019
@hgiesel
Copy link
Owner Author

hgiesel commented Dec 5, 2019

Rather than merging, test uniqNames separately, and return a special value, indicating whether a rejection came from uniqName, or from uniqCond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hgiesel