Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Anki hooks rather than wrap #7

Open
hgiesel opened this issue Mar 17, 2020 · 2 comments
Open

Use Anki hooks rather than wrap #7

hgiesel opened this issue Mar 17, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@hgiesel
Copy link
Owner

hgiesel commented Mar 17, 2020

This can only be accomplished once there is a anki hook, where we can inspect the incoming revlog entries.

The closest thing right now is hooks.sync_stage_did_change.append().
@bmulholland
Copy link

See discussion here: https://anki.tenderapp.com/discussions/add-ons/42645-getting-collection-during-new-style-sync-hook

@hgiesel hgiesel added the enhancement New feature or request label Mar 18, 2020
@hgiesel
Copy link
Owner Author

hgiesel commented May 23, 2020

As of today, the only wrap that remains is around AnkiQt._sync in the sync_hook.

@hgiesel hgiesel changed the title Use Anki hooks rather than wrap in sync_hook Use Anki hooks rather than wrap May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmulholland @hgiesel