Skip to content
This repository has been archived by the owner on Nov 9, 2021. It is now read-only.

The SetFieldsOptions interface might be redundant #353

Open
williamfeng323 opened this issue Apr 16, 2018 · 0 comments
Open

The SetFieldsOptions interface might be redundant #353

williamfeng323 opened this issue Apr 16, 2018 · 0 comments

Comments

@williamfeng323
Copy link

Hi,
This squel project is amazing! I am using it with Typescript. While I explore the project, I found the squel.d.ts file separate interface SetOptions and interface SetfieldsOptions, however, the setFeilds function is calling set function by looping the fields. So I think this interface could reuse type SetOptions instead of SetFieldsOptions.

Currently, I have to write codes like squel.insert().into(table).setFields(tempVal, { dontQuote: true } as squel.FieldOptions).toString(); to use dontQuote option.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant