Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependecy of walletconnect/qrcode-modal for mirror-node-explorer #26

Open
hendrikebbers opened this issue Oct 10, 2024 · 2 comments
Labels
hashgraph transfer Related to the transfer of the Hashgraph projects license issue

Comments

@hendrikebbers
Copy link
Contributor

hendrikebbers commented Oct 10, 2024

As mentioned in #15 we currently depened on walletconnect/[email protected] that shows as LGPL licensed in Snyk. I do not know if it is https://github.com/walletconnect/walletconnect-monorepo or https://github.com/walletconnect/modal but both have way never versions under apache licence. A search at NPM does not show an exact match for the current dependency: https://www.npmjs.com/search?q=walletconnect%2Fqrcode-modal

@ericleponner
Copy link

@walletconnect/[email protected] is an indirect dependency generated by blade-web3.js (the library to access Blade Wallet extension):

npm list @walletconnect/[email protected]
[email protected] /WS/hedera-mirror-node-explorer-clean
└─┬ @bladelabs/[email protected]
  └─┬ @hashgraph/[email protected]
    └── @walletconnect/[email protected]

@hendrikebbers hendrikebbers added the hashgraph transfer Related to the transfer of the Hashgraph projects label Nov 19, 2024
@svienot
Copy link

svienot commented Dec 11, 2024

We have now moved to using WalletConnect in the Explorer and hence are no longer using the blade-web3.js library.
There should not be any indirect dependency on @walletconnect/[email protected] now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashgraph transfer Related to the transfer of the Hashgraph projects license issue
Projects
None yet
Development

No branches or pull requests

3 participants