Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 'cachePath' with absolute path #562

Open
nhitchins opened this issue Aug 6, 2024 · 4 comments
Open

v4 'cachePath' with absolute path #562

nhitchins opened this issue Aug 6, 2024 · 4 comments
Assignees

Comments

@nhitchins
Copy link

nhitchins commented Aug 6, 2024

Expected behaviour

highcharts.cachePath or HIGHCHARTS_CACHE_PATH env var should allow an absolute path such as '/tmp/.cache'

Actual behaviour

Previously (v3) if the manifest.json file existed in the 'node_modules/highcharts-export-server/.cache' directory but read-only it would log an error and initPool would continue to start. Now initExport throws an error.

Reproduction steps

Set the 'node_modules/highcharts-export-server/.cache/manifest.json' file as read-only and initExport will throw an error.
Ideally just allow cachePath to specify an absolute path and if the manifest.json file exists (and un-changed) then skip writing new manifest

@DanielRuf
Copy link

All hardcoded paths should be configurable (with default values as fallbacks) in my opinion.

@jszuminski
Copy link
Contributor

@nhitchins @DanielRuf feel free to test out #576 and let me know if absolute path for the Highcharts cache works as expected now.

@jszuminski jszuminski self-assigned this Sep 2, 2024
@nhitchins
Copy link
Author

@jszuminski Working now with absolute path - confirmed!

@jszuminski
Copy link
Contributor

jszuminski commented Sep 3, 2024

Great, thanks for the info! I will close this issue once we merge the PR.

@jszuminski jszuminski reopened this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants