Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: make userDataDir configurable #567

Open
DanielRuf opened this issue Aug 7, 2024 · 2 comments · May be fixed by #569
Open

v4: make userDataDir configurable #567

DanielRuf opened this issue Aug 7, 2024 · 2 comments · May be fixed by #569
Assignees

Comments

@DanielRuf
Copy link

Depending on the context in which the CLI is started, the path results in a different absolute path.

Please make this configurable to prevent, that it creates the tmp folder in the wrong place.

https://github.com/highcharts/node-export-server/blob/master/lib/browser.js#L69

@jszuminski jszuminski self-assigned this Aug 13, 2024
@jszuminski
Copy link
Contributor

Thanks for reporting @DanielRuf! I've added it to our backlog and will try to make it a part of the next minor release.

@jszuminski jszuminski linked a pull request Aug 13, 2024 that will close this issue
5 tasks
jszuminski added a commit that referenced this issue Aug 13, 2024
@jszuminski jszuminski linked a pull request Aug 21, 2024 that will close this issue
5 tasks
@jszuminski
Copy link
Contributor

@DanielRuf feel free to test out this pull request and let me know if that's what you were looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants