Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Limit/Inefficient data transfer of chart data (options) to the browser #570

Open
daniatic opened this issue Aug 14, 2024 · 1 comment
Labels

Comments

@daniatic
Copy link

daniatic commented Aug 14, 2024

Expected behavior

The export server should handle large amounts of data. The technical limitation is likely due to the Chrome DevTools protocol implementation, which is capped at 100 MB. This allows for approximately 12,979,200 data points to be transferred (assuming double precision at 8 bytes per point). However, some bytes should be reserved for other settings within the options object.

Additionally, the exporter crashes without a proper error message when the 100 MB limit is exceeded.

Actual behavior

Data is transferred as a string representation of the JSON object, which consumes more than twice the amount of data per data point. We are currently observing a limit of around 2,550,000 data points, resulting in a JSON string of roughly 100 MB. I expected it to be around 50 MB, but the data appears redundant in the transferred message (data.params.arguments[1].value.export.options and data.params.arguments[1].value.export.strInj).

The exporter should not crash when the limit is exceeded. Instead, it should log the specific reason.

One potential solution could be to serialize the JSON to BSON, transfer it as binary data, and then deserialize it back to JSON on the client side.

Reproduction steps

Render a chart with 3 million data points and observe the service crashing.

@jszuminski jszuminski added the bug label Aug 15, 2024
@jszuminski
Copy link
Contributor

Thanks for reporting @daniatic!

I have added it to our backlog and we will investigate this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants