v4: no error is thrown when callback is set and it's a file but allowFileResources is not set to true

[DanielRuf]

When we set allowCodeExecution to false, we get The 'callback', 'resources' and 'customCode' options have been disabled for this server.

When we set allowCodeExecution to true, we get no error.

But when we set callback to a file, it silently ignores it. No error or warning is provided, that allowFileResources has to be enabled / set to true.

That is not ideal and makes debugging harder.

node-export-server/lib/chart.js

Line 416 in e740944

if (customLogicOptions.allowFileResources) {

To reproduce:

highcharts-export-server --allowCodeExecution true --logToFile false --infile "....in.js" --outfile "...out.jpg" --type "jpg" --globalOptions "....globalOptions.json" --callback "some-invalid-path.js" --width 600 throws no error.

highcharts-export-server --allowCodeExecution true --logToFile false --infile "....in.js" --outfile "...out.jpg" --type "jpg" --globalOptions "....globalOptions.js" --callback "some-invalid-path.js" --allowFileResources true --width 600 throws error no such file or directory, open 'some-invalid-path.json'

[DanielRuf]

Also no error is thrown if the file defined for --globalOptions contains invalid JSON.

[jszuminski]

Thanks for reporting @DanielRuf!

You're right - it should be solved on our side. I have added this to our backlog.

Regarding your second point, @PaulDalek is currently working on this here: #561 (full options validation with zod)