Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http is being used #11

Open
SurinameClubcard opened this issue Feb 14, 2022 · 0 comments · May be fixed by #14
Open

http is being used #11

SurinameClubcard opened this issue Feb 14, 2022 · 0 comments · May be fixed by #14
Assignees
@kevinvaldek

Comments

@SurinameClubcard
Copy link

Observation: In AuthController there are at least two occasions where http is being used.

hm-graphql-auto-api-explorer/server/controllers/AuthController.js

Line 10 in ababbd4

`http://${req.hostname}${

hm-graphql-auto-api-explorer/server/controllers/AuthController.js

Line 17 in ababbd4

`http://${req.hostname}${

Expectation: do not use http? At least not hard coded this way; if the original request was http by itself, it is understandable, but if not (e.g., because https was used), why suddenly do http?
@kaareloun kaareloun linked a pull request Feb 15, 2022 that will close this issue
use https #14
Open
@kevinvaldek kevinvaldek self-assigned this Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinvaldek kevinvaldek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use https highmobility/hm-graphql-auto-api-explorer
2 participants
@kevinvaldek @SurinameClubcard