Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on React-Native 0.22.2 #18

Open
pranjaltech opened this issue Mar 29, 2016 · 1 comment
Open

Does not work on React-Native 0.22.2 #18

pranjaltech opened this issue Mar 29, 2016 · 1 comment

Comments

@pranjaltech
Copy link

Throws this error -


It works if I update the package.json of your repo to use moment ^2.12.0 and run npm install again.
Is there a pitfall to this solution? Or would you accept a PR for this?

@dantman
Copy link

dantman commented Apr 14, 2016

Same issue here. This package shouldn't be depending on moment with a ~ semver restriction, that's far too restrictive and even without this error would break this library since the difference in version will cause moment-twitter to load a duplicate moment library and modify it instead of the moment library required by the developer.

The proper way would be a peer dep and at minimum a ^ dependency, if not a >= dep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants