Skip to content
This repository has been archived by the owner on Jan 2, 2023. It is now read-only.

added the feature that only number will be input in the mobile numbr and chat bot feature #439

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tanyajha16
Copy link

… not text

Description

I have added the feature that only numbers will be inputed in the mobile no area in contact us page and have done spme changes in css so that the form looks similar for all the input tags

Fixes#328

Type of change

changes done:

  1. increased the width of the input tag of the mobile number to match with other input tags
  2. added border radius in it
  3. made the input tag to accept only numbers and no texts
  • [X ] Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)

Explain the Testing instructions

Test Configuration:

  • Operating system:
  • Version:
  • Text-editors used:

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

ATTACH SCREEN-SHOTS

image
image

@netlify
Copy link

netlify bot commented Aug 29, 2021

❌ Deploy Preview for quirky-kilby-87cc28 failed.

🔨 Explore the source changes: 583f2ba

🔍 Inspect the deploy log: https://app.netlify.com/sites/quirky-kilby-87cc28/deploys/612bdd96adfc550007984af7

@tanyajha16
Copy link
Author

this pr solves issue#328

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉Congratulations!!🎉 for making your first PR , our mentors will review it soon.

@@ -96,7 +96,7 @@ <h1 class="heading">CONTACT-US</h1>
required="">
<label for="telephone">Mobile Number : </label>

<input type="telephone" name="telephone" id="telephone" placeholder="+91 1234567890">
<input type="number" name="telephone" id="telephone" placeholder="+91 1234567890">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace "number" with "tel". see this documentation.

@tanyajha16 tanyajha16 changed the title added the feature that only number will be input in the mobile number… added the feature that only number will be input in the mobile numbr and chat bot feature Aug 29, 2021
@tanyajha16
Copy link
Author

chat bot feature added which fixes #9

@himanshu007-creator
Copy link
Owner

@tanyajha16, please remove this chatbot feature. After a detailed inner discussion, we decided not to move forward with this. For now just work on the above suggested changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow only numeric data inside the Mobile number field in Contact Us form
2 participants