-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show signer performance data by cycle #1869
Comments
I recommend adding these columns (Latency, Approved, Rejected, Missing) to the Signers Page table: Additionally, I suggest introducing a new In both the Stacking history table and the Signed Transactions column, users will be able to filter by cycle, similar to how the existing Date filter works: This structure will align with the upcoming redesign, including the new Stacking and Cycle pages. On the new Stacking page, users will see current Stacking data, while the Cycle pages will allow for more detailed inspection of Pools and Signers data on a per-cycle basis. Let me know if you have any feedback |
This isn't in the task, nor the design, but there was also an ask to add this data to the blocks page...I think the ask originated from API/Heidar? I assume that task is still active considering we are adding signer data to blocks (context here) @smcclellan mentioned adding these data points "Something like approved/rejected/missing, possibly in weighted%, plus average latency perhaps, would be a great start." Based on the API endpoints prototype I should have that data:
Additionally, @smcclellan asked about adding the ability to see past cycles on the Signers table (context here) @andresgalante Please let me know if my understanding is correct here and if I missed anything |
Also, I am splitting out the work for creating the Signer ID page into its own task here #1878 |
Let's do this in 2 iterations: Phase 1:
We can ship this using the current API support. Phase 2: signer ID page. |
To clarify, the control to change cycles on the Signers page table isn't included in the current design to avoid extra adjustments and have more consistency when the new redesign is implemented. Like the new Stacking page, which only displays current data (this cycle, next cycle) and recent activity (active pools from the last 3 cycles), the Signers page is intended to focus on current vs. historical data. This is because it's unclear how useful it would be for users to explore signers from 10 cycles ago. That being said, historical signer activity will still be accessible via the "Signer ID" page (for individual signers) and the new "Stacking Cycle ID" page (for all signers in a specific cycle). I'm open to adding the "Cycle" filter in this version but wanted to explain why it wasn’t in the initial design. Let’s discuss further when viewing the new designs if that helps clarify. Here's the updated Signers page table with the "Cycle" filter button: |
Thanks @ginny-d for the clarification, we understood the intention of the designs, but since we might need a bit more time to implement the signer ID page then I thought it'd be a good idea to ship a first iteration with the cycle selector on the table. Although it seems that it might be sooner rather than later https://hiropbc.slack.com/archives/C03UFUA5Q65/p1729795614623549 @BLuEScioN Please take a look at this thread about optimizing the table horizontal space https://hiropbc.slack.com/archives/C03TU42NL05/p1729796480027399 |
Is your feature request related to a problem? Please describe.
As signer performance data is being added to an API, it would be great for this data to be displayed on the Signers page. Some questions that a user may want to answer with this data:
Describe the solution you'd like
Show, for each signer, latency ("Latency" -- in ms) plus approved/rejected/missing ("Voting" -- X/Y/Z) stats.
Allow paging through cycles, starting with the current cycle.
Additional context
The most helpful data to show on the approved/rejected/missing side could vary, from # votes to weightings to based on # stacked.
The text was updated successfully, but these errors were encountered: