Skip to content

Commit 2ae89cf

Browse files
committed
Cleanup builders
1 parent cd65bad commit 2ae89cf

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

src/main/java/com/hivemq/mqtt/client2/internal/MqttRxClientBuilder.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public MqttRxClientBuilder() {}
9090
}
9191

9292
@Override
93-
public @NotNull MqttRxClientBuilder advancedConfig(final @NotNull Mqtt5AdvancedConfig advancedConfig) {
93+
public @NotNull MqttRxClientBuilder advancedConfig(final @Nullable Mqtt5AdvancedConfig advancedConfig) {
9494
this.advancedConfig = Checks.notImplemented(advancedConfig, MqttAdvancedConfig.class, "Advanced config");
9595
return this;
9696
}

src/main/java/com/hivemq/mqtt/client2/internal/message/connect/MqttConnectRestrictionsBuilder.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,8 @@ public Default() {}
125125
public static class Nested<P> extends MqttConnectRestrictionsBuilder<Nested<P>>
126126
implements Mqtt5ConnectRestrictionsBuilder.Nested<P>, Mqtt3ConnectRestrictionsBuilder.Nested<P> {
127127

128+
private final @NotNull Function<? super MqttConnectRestrictions, P> parentConsumer;
129+
128130
public Nested(
129131
final @NotNull MqttConnectRestrictions restrictions,
130132
final @NotNull Function<? super MqttConnectRestrictions, P> parentConsumer) {
@@ -133,8 +135,6 @@ public Nested(
133135
this.parentConsumer = parentConsumer;
134136
}
135137

136-
private final @NotNull Function<? super MqttConnectRestrictions, P> parentConsumer;
137-
138138
@Override
139139
@NotNull Nested<P> self() {
140140
return this;

src/main/java/com/hivemq/mqtt/client2/internal/mqtt3/Mqtt3RxClientViewBuilder.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,11 @@ public Mqtt3RxClientViewBuilder(
7777
}
7878
}
7979

80+
@Override
81+
protected @NotNull Mqtt3RxClientViewBuilder self() {
82+
return this;
83+
}
84+
8085
private @NotNull MqttConnectedListener<MqttConnectedContextImpl> wrapConnectedListener(
8186
final @NotNull MqttConnectedListener<? super Mqtt3ConnectedContextView> delegate) {
8287
return context -> delegate.onConnected(new Mqtt3ConnectedContextView(context));
@@ -129,11 +134,6 @@ public Mqtt3RxClientViewBuilder(
129134
return new Mqtt3PublishViewBuilder.WillNested<>(this::willPublish);
130135
}
131136

132-
@Override
133-
protected @NotNull Mqtt3RxClientViewBuilder self() {
134-
return this;
135-
}
136-
137137
@Override
138138
public @NotNull Mqtt3RxClientView build() {
139139
return buildRx();

0 commit comments

Comments
 (0)