Skip to content

Commit 5be79fd

Browse files
Move class-transformer call to improve performance (#633)
* Move class-transformer call to improve performance * Version number amend
1 parent dceabf6 commit 5be79fd

File tree

5 files changed

+9
-5
lines changed

5 files changed

+9
-5
lines changed

RELEASE-NOTES.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
## RELEASE NOTES
22

3+
### Version 2.66.0
4+
**EUI-2741** Improve performance time when loading a case with large hearing and judgement collections
5+
36
### Version 2.65.6
47
**EUI** bumping up
58

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@hmcts/ccd-case-ui-toolkit",
3-
"version": "2.65.6",
3+
"version": "2.66.0-performance-issue-tribunals",
44
"engines": {
55
"yarn": "^1.12.3",
66
"npm": "^5.6.0"

src/shared/components/case-viewer/case-viewer.component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import { MatDialog, MatDialogConfig } from '@angular/material';
1919
import { CaseNotifier } from '../case-editor';
2020
import { NavigationNotifierService, NavigationOrigin } from '../../services/navigation';
2121
import { ErrorNotifierService } from '../../services/error';
22+
import { plainToClass } from 'class-transformer';
2223

2324
@Component({
2425
selector: 'ccd-case-viewer',
@@ -209,7 +210,7 @@ export class CaseViewerComponent implements OnInit, OnDestroy {
209210

210211
private getTabFields(): CaseField[] {
211212
const caseDataFields = this.sortedTabs.reduce((acc, tab) => {
212-
return acc.concat(tab.fields);
213+
return acc.concat(plainToClass(CaseField, tab.fields));
213214
}, []);
214215

215216
return caseDataFields.concat(this.caseDetails.metadataFields);

src/shared/components/palette/base-field/field-read.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { PaletteService } from '../palette.service';
33
import { AbstractFieldReadComponent } from './abstract-field-read.component';
44
import { CaseField } from '../../../domain/definition/case-field.model';
55
import { FormGroup } from '@angular/forms';
6-
import { plainToClassFromExist } from 'class-transformer';
76
import { FieldsUtils } from '../../../services/fields';
87

98
@Component({
@@ -38,7 +37,7 @@ export class FieldReadComponent extends AbstractFieldReadComponent implements On
3837
let component = this.resolver.resolveComponentFactory(componentClass).create(injector);
3938

4039
// Provide component @Inputs
41-
component.instance['caseField'] = plainToClassFromExist(new CaseField(), this.caseField);
40+
component.instance['caseField'] = this.caseField;
4241
component.instance['caseFields'] = this.caseFields;
4342
component.instance['formGroup'] = this.formGroup;
4443
component.instance['caseReference'] = this.caseReference;

src/shared/components/palette/history/event-log/event-log-table.component.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,8 @@ describe('EventLogTableComponent', () => {
108108
expect(firstRowCells.length).toBe(3);
109109
let firstEvent = EVENTS[0];
110110

111-
const timeZoneOffset = -(new Date().getTimezoneOffset());
111+
const date = new Date(2017, 4, 10); // 10th May, 2017
112+
const timeZoneOffset = - (new Date(date).getTimezoneOffset());
112113

113114
expect(firstRowCells[COL_EVENT].nativeElement.textContent).toBe(firstEvent.event_name + firstEvent.significant_item.description);
114115
expect(firstRowCells[COL_DATE].nativeElement.textContent)

0 commit comments

Comments
 (0)