Feature/eui 1370 complex type aa (#605)

* EUI-1370 some initial work

* EUI-1370 work done and tests

* EUI-1370 @£$%^&*(*&^%$ linting

* EUI-1370 some initial work

* EUI-1370 work done and tests

* EUI-1370 @£$%^&*(*&^%$ linting

* EUI-1370 fixed bug relating to startsWith

* EUI-1370 release details

Author: adnanakgun

RELEASE-NOTES.md

@@ -1,4 +1,7 @@
 ## RELEASE NOTES
+### Version 2.64.52-collection-permission
+**EUI-1370** UI When using case role collection of complex types doesn't seem to work
+
 ### Version 2.64.50-case-share-hot-fix
 * correct and cherry-pick the right commits
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hmcts/ccd-case-ui-toolkit",
-  "version": "2.64.51-retain-hidden-value-complex-and-collection-types-fix",
+  "version": "2.64.52-collection-permission",
   "engines": {
     "yarn": "^1.12.3",
     "npm": "^5.6.0"

src/shared/components/palette/collection/write-collection-field.component.spec.ts

@@ -90,6 +90,7 @@ describe('WriteCollectionFieldComponent', () => {
       label: 'X',
       field_type: SIMPLE_FIELD_TYPE,
       display_context: 'OPTIONAL',
+      display_context_parameter: '#COLLECTION(allowInsert)',
       value: VALUES.slice(0),
       acls: [
         {
@@ -255,6 +256,13 @@ describe('WriteCollectionFieldComponent', () => {
   });
 
   it('should display removal confirmation dialog when remove button is clicked', () => {
+    const tempCaseField = <CaseField>({
+      ...caseField,
+      display_context_parameter: '#COLLECTION(allowInsert,allowDelete)'
+    });
+    component.caseFields = [tempCaseField];
+    component.ngOnInit();
+    fixture.detectChanges();
     let removeButtons = de.queryAll($REMOVE_BUTTONS);
 
     let removeFirstButton = removeButtons[0];
@@ -265,6 +273,19 @@ describe('WriteCollectionFieldComponent', () => {
   });
 
   it('should remove item from collection when remove button is clicked and confirmed', () => {
+    const tempCaseField = <CaseField>({
+      ...caseField,
+      display_context_parameter: '#COLLECTION(allowInsert,allowDelete)'
+    });
+    component.caseField = tempCaseField;
+    component.caseFields = [tempCaseField];
+    component.ngOnInit();
+    fixture.detectChanges();
+    // Manually populate the form array as item field are mocked and can't register themselves
+    VALUES.forEach((collectionItem, index) => {
+      component.buildControlRegistrer(collectionItem.id, index)(new FormControl(collectionItem.value));
+    });
+    fixture.detectChanges();
     // Confirm removal through mock dialog
     dialogRef.afterClosed.and.returnValue(of('Remove'));
 

src/shared/components/palette/collection/write-collection-field.component.ts

@@ -140,11 +140,14 @@ export class WriteCollectionFieldComponent extends AbstractFieldWriteComponent i
     if (this.isExpanded) {
       return false;
     }
-    return !this.profile.user.idam.roles.find(role => this.hasCreateAccess(role));
+    return !this.getCollectionPermission(this.caseField, 'allowInsert');
   }
 
-  hasCreateAccess(role: any) {
-    return !!this.caseField.acls.find( acl => acl.role === role && acl.create === true);
+  getCollectionPermission(field: CaseField, type: string) {
+    return field.display_context_parameter &&
+            field.display_context_parameter.split('#')
+              .filter(item => item.startsWith('COLLECTION('))[0]
+                .includes(type);
   }
 
   isNotAuthorisedToUpdate(index: number) {
@@ -170,11 +173,7 @@ export class WriteCollectionFieldComponent extends AbstractFieldWriteComponent i
     if (this.formArray.at(index)) {
       id = this.formArray.at(index).get('id').value;
     }
-    return !!id && !this.profile.user.idam.roles.find(role => this.hasDeleteAccess(role));
-  }
-
-  hasDeleteAccess(role: any): boolean {
-    return !!this.caseField.acls.find(acl => acl.role === role && acl.delete === true);
+    return !!id && !this.getCollectionPermission(this.caseField, 'allowDelete');
   }
 
   openModal(i: number) {