diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 03f2738b7..8d65cfd07 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -1,5 +1,8 @@ ## RELEASE NOTES +### Version 7.2.55 +**EXUI-3552** Some of the requests for document create are going to XUI and not CDAM + ### Version 7.2.54 **EXUI-3555** Judges should be able to respond to queries diff --git a/package.json b/package.json index 76285f182..4c0e5c0af 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@hmcts/ccd-case-ui-toolkit", - "version": "7.2.54", + "version": "7.2.55", "engines": { "node": ">=18.19.0" }, diff --git a/projects/ccd-case-ui-toolkit/package.json b/projects/ccd-case-ui-toolkit/package.json index 007df95b5..614732255 100644 --- a/projects/ccd-case-ui-toolkit/package.json +++ b/projects/ccd-case-ui-toolkit/package.json @@ -1,6 +1,6 @@ { "name": "@hmcts/ccd-case-ui-toolkit", - "version": "7.2.54", + "version": "7.2.55", "engines": { "node": ">=18.19.0" }, diff --git a/projects/ccd-case-ui-toolkit/src/lib/shared/components/palette/document/write-document-field.component.spec.ts b/projects/ccd-case-ui-toolkit/src/lib/shared/components/palette/document/write-document-field.component.spec.ts index 0fc50fb2d..e1ac04552 100644 --- a/projects/ccd-case-ui-toolkit/src/lib/shared/components/palette/document/write-document-field.component.spec.ts +++ b/projects/ccd-case-ui-toolkit/src/lib/shared/components/palette/document/write-document-field.component.spec.ts @@ -139,7 +139,7 @@ describe('WriteDocumentFieldComponent', () => { 'isUploadInProgress' ]); - appConfig = createSpyObj('AbstractAppConfig', ['getCdamExclusionList']); + appConfig = createSpyObj('AbstractAppConfig', ['getCdamExclusionList', 'logMessage']); mockDocumentManagementService.isDocumentSecureModeEnabled.and.returnValue(true); caseNotifier = {}; caseNotifier.caseView = of({ case_type: { id: 'test' } }); @@ -692,7 +692,7 @@ describe('WriteDocumentFieldComponent with Mandatory casefield', () => { 'isUploadInProgress' ]); - appConfig = createSpyObj('AbstractAppConfig', ['getCdamExclusionList']); + appConfig = createSpyObj('AbstractAppConfig', ['getCdamExclusionList', 'logMessage']); mockDocumentManagementService.isDocumentSecureModeEnabled.and.returnValue(true); caseNotifier = {}; caseNotifier.caseView = of({ case_type: { id: 'test' } }); @@ -772,6 +772,36 @@ describe('WriteDocumentFieldComponent with Mandatory casefield', () => { expect(component.fileUploadMessages).toEqual('File required'); }); + it('should be logged as enabled if file is securemode', () => { + component.caseField = CASE_FIELD_MANDATORY; + mockDocumentManagementService.isDocumentSecureModeEnabled.and.returnValue(true); + caseNotifier.caseView = of({ case_id: '12345', case_type: { id: 'test', jurisdiction: { id: 'test-jurisdiction' } } }); + component.ngOnInit(); + expect(component.caseField.value).toBeTruthy(); + + component.fileChangeEvent({ + target: { + files: [] + } + }); + expect(appConfig.logMessage).toHaveBeenCalledWith('CDAM is enabled for case with case ref:: 12345'); + }); + + it('should be logged as disabled if file is NOT securemode', () => { + component.caseField = CASE_FIELD_MANDATORY; + mockDocumentManagementService.isDocumentSecureModeEnabled.and.returnValue(false); + caseNotifier.caseView = of({ case_id: '12345', case_type: { id: 'test', jurisdiction: { id: 'test-jurisdiction' } } }); + component.ngOnInit(); + expect(component.caseField.value).toBeTruthy(); + + component.fileChangeEvent({ + target: { + files: [] + } + }); + expect(appConfig.logMessage).toHaveBeenCalledWith('CDAM is disabled for case with case ref:: 12345'); + }); + it('should be valid if no document specified for upload for not read only. Empty file.', () => { // Initialization. component.valid = true; @@ -918,7 +948,7 @@ describe('WriteDocumentFieldComponent', () => { 'isUploadInProgress' ]); - appConfig = createSpyObj('AbstractAppConfig', ['getCdamExclusionList']); + appConfig = createSpyObj('AbstractAppConfig', ['getCdamExclusionList', 'logMessage']); mockDocumentManagementService.isDocumentSecureModeEnabled.and.returnValue(true); caseNotifier = {}; caseNotifier.caseView = of(undefined); diff --git a/projects/ccd-case-ui-toolkit/src/lib/shared/components/palette/document/write-document-field.component.ts b/projects/ccd-case-ui-toolkit/src/lib/shared/components/palette/document/write-document-field.component.ts index 8da644e17..0c6c62e49 100644 --- a/projects/ccd-case-ui-toolkit/src/lib/shared/components/palette/document/write-document-field.component.ts +++ b/projects/ccd-case-ui-toolkit/src/lib/shared/components/palette/document/write-document-field.component.ts @@ -94,7 +94,10 @@ export class WriteDocumentFieldComponent extends AbstractFieldWriteComponent imp } // use the documentManagement service to check if the document upload should use CDAM if (this.documentManagement.isDocumentSecureModeEnabled()) { + this.appConfig.logMessage(`CDAM is enabled for case with case ref:: ${caseDetails?.case_id}`); this.fileSecureModeOn = true; + } else { + this.appConfig.logMessage(`CDAM is disabled for case with case ref:: ${caseDetails?.case_id}`); } this.dialogConfig = initDialog(); let document = this.caseField.value || { document_url: null, document_binary_url: null, document_filename: null }; diff --git a/projects/ccd-case-ui-toolkit/src/lib/shared/services/document-management/document-management.service.spec.ts b/projects/ccd-case-ui-toolkit/src/lib/shared/services/document-management/document-management.service.spec.ts index 750206524..59945e2ea 100644 --- a/projects/ccd-case-ui-toolkit/src/lib/shared/services/document-management/document-management.service.spec.ts +++ b/projects/ccd-case-ui-toolkit/src/lib/shared/services/document-management/document-management.service.spec.ts @@ -25,7 +25,7 @@ describe('DocumentManagementService', () => { appConfig = createSpyObj('appConfig', [ 'getDocumentManagementUrl', 'getRemoteDocumentManagementUrl', 'getHrsUrl', 'getRemoteHrsUrl', - 'getAnnotationApiUrl', 'getCdamExclusionList', 'getDocumentManagementUrlV2' + 'getAnnotationApiUrl', 'getCdamExclusionList', 'getDocumentManagementUrlV2', 'logMessage' ]); appConfig.getRemoteDocumentManagementUrl.and.returnValue(REMOTE_DOCUMENT_MANAGEMENT_URL); appConfig.getDocumentManagementUrl.and.returnValue(DOCUMENT_MANAGEMENT_URL); diff --git a/projects/ccd-case-ui-toolkit/src/lib/shared/services/document-management/document-management.service.ts b/projects/ccd-case-ui-toolkit/src/lib/shared/services/document-management/document-management.service.ts index cad784a42..8c33d92b2 100644 --- a/projects/ccd-case-ui-toolkit/src/lib/shared/services/document-management/document-management.service.ts +++ b/projects/ccd-case-ui-toolkit/src/lib/shared/services/document-management/document-management.service.ts @@ -63,6 +63,7 @@ export class DocumentManagementService { // Do not set any headers, such as "Accept" or "Content-Type", with null values; this is not permitted with the // Angular HttpClient in @angular/common/http. Just create and pass a new HttpHeaders object. Angular will add the // correct headers and values automatically + this.appConfig.logMessage(`Uploading document for case type: ${this.caseTypeId}, with url: ${url}`); const headers = new HttpHeaders(); return this.http .post(url, formData, {headers, observe: 'body'}) @@ -145,7 +146,7 @@ export class DocumentManagementService { public isDocumentSecureModeEnabled(): boolean { const documentSecureModeCaseTypeExclusions = this.appConfig.getCdamExclusionList()?.split(','); const isDocumentOnExclusionList = documentSecureModeCaseTypeExclusions?.includes(this.caseTypeId); - + this.appConfig.logMessage(`isDocumentOnExclusionList: ${isDocumentOnExclusionList}`); if (!isDocumentOnExclusionList){ return true; }