Add support for MU prefix in ACAS number validation and update tests (#2141)

Author: hsjhita

src/main/components/form/validator.ts

@@ -207,7 +207,7 @@ export const isNotPdfFileType = (value: Express.Multer.File): string => {
 
 export const isAcasNumberValid: Validator = value => {
   const valueAsString = value as string;
-  if (!/^[rR]\d{6}\/\d{2}\/\d{2}$/.test(valueAsString)) {
+  if (!/^(?:[rR]|[mM][uU])\d{6}\/\d{2}\/\d{2}$/.test(valueAsString)) {
     return 'invalidAcasNumber';
   }
 };

src/main/controllers/AcasCertNumController.ts

@@ -42,7 +42,7 @@ export default class AcasCertNumController {
                 label: (l: AnyRecord): string => l.acasCertNum,
                 labelAsHint: true,
                 classes: 'govuk-textarea',
-                attributes: { maxLength: 13 },
+                attributes: { maxLength: 14 },
               },
             },
           },

src/test/unit/components/validator.test.ts

@@ -320,7 +320,7 @@ describe('Validation', () => {
       expect(isValid).toStrictEqual('invalidAcasNumber');
     });
 
-    it('Should check if value starts with R', () => {
+    it('Should check if value starts with R or MU', () => {
       const beginsWithT = isAcasNumberValid('T123458/89/13');
       const beginsWithQ = isAcasNumberValid('q123456/78/12');
       const beginsWithDigit = isAcasNumberValid('1234556/79/12');
@@ -330,10 +330,12 @@ describe('Validation', () => {
       expect(beginsWithDigit).toStrictEqual('invalidAcasNumber');
     });
 
-    it('Should check if has any numeric or / character after R', () => {
-      const isValid = isAcasNumberValid('R12345/789a12');
+    it('Should check if has any numeric or / character after R or MU', () => {
+      const invalidAfterR = isAcasNumberValid('R12345/789a12');
+      const invalidAfterMU = isAcasNumberValid('MU12345/789a12');
 
-      expect(isValid).toStrictEqual('invalidAcasNumber');
+      expect(invalidAfterR).toStrictEqual('invalidAcasNumber');
+      expect(invalidAfterMU).toStrictEqual('invalidAcasNumber');
     });
 
     it('Should check if has any repeating / character like //', () => {
@@ -386,10 +388,33 @@ describe('Validation', () => {
       expect(isValid).toStrictEqual(undefined);
     });
 
-    it('Should validate corect RNNNNNN/NN/NN format', () => {
+    it('Should allow MU prefix in any case', () => {
+      const mu = isAcasNumberValid('MU123456/78/12');
+      const Mu = isAcasNumberValid('Mu123456/78/12');
+      const mU = isAcasNumberValid('mU123456/78/12');
+      const muLower = isAcasNumberValid('mu123456/78/12');
+      expect(mu).toStrictEqual(undefined);
+      expect(Mu).toStrictEqual(undefined);
+      expect(mU).toStrictEqual(undefined);
+      expect(muLower).toStrictEqual(undefined);
+    });
+
+    it('Should reject RU and RMU prefixes', () => {
+      const ru = isAcasNumberValid('RU123456/78/12');
+      const rmu = isAcasNumberValid('RMU123456/78/12');
+      expect(ru).toStrictEqual('invalidAcasNumber');
+      expect(rmu).toStrictEqual('invalidAcasNumber');
+    });
+
+    it('Should validate correct RNNNNNN/NN/NN format', () => {
       const isValid = isAcasNumberValid('R123456/78/12');
       expect(isValid).toStrictEqual(undefined);
     });
+
+    it('Should validate correct MUNNNNNN/NN/NN format', () => {
+      const isValid = isAcasNumberValid('MU123456/78/12');
+      expect(isValid).toStrictEqual(undefined);
+    });
   });
   describe('isContent100CharsOrLess()', () => {
     it('should not warn when content is 100 characters or less', () => {

src/test/unit/controller/AcasCertNumController.test.ts

@@ -122,4 +122,15 @@ describe('Acas Cert Num Controller', () => {
     expect(req.session.userCase.respondents[0].acasCertNum).toEqual('R123456/12/34');
     expect(req.session.userCase.respondents[0].acasCert).toEqual(YesOrNo.YES);
   });
+
+  it('should add MU acas number to the session userCase', async () => {
+    const body = { acasCert: YesOrNo.YES, acasCertNum: 'MU123456/12/34' };
+    const controller = new AcasCertNumController();
+    const req = mockRequest({ body });
+    const res = mockResponse();
+
+    await controller.post(req, res);
+    expect(req.session.userCase.respondents[0].acasCertNum).toEqual('MU123456/12/34');
+    expect(req.session.userCase.respondents[0].acasCert).toEqual(YesOrNo.YES);
+  });
 });