Skip to content

Commit b9ae258

Browse files
update wording and remove consent part
1 parent de3132b commit b9ae258

File tree

8 files changed

+15
-90
lines changed

8 files changed

+15
-90
lines changed

ccd-definition/CaseField/CareSupervision/hearingOrders.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1239,7 +1239,7 @@
12391239
"LiveFrom": "01/01/2017",
12401240
"CaseTypeID": "CARE_SUPERVISION_EPO",
12411241
"ID": "previewOrderLabel",
1242-
"Label": "Cover sheets will be automatically added to the following C21 orders. If the content is incorrect, please return to the previous step and upload a revised document.",
1242+
"Label": "If you click 'Continue', the draft order will be approved without any changes. A coversheet will be added showing your name and the date of approval, and a court seal will also be applied to the final version.<br/><br/>Please note that the preview shown below will not display the court seal, but it reflects the content that will be issued.<br/><br/>If you wish to make any amendments, please return to the previous screen and select either 'No, I need to make changes' or 'No, the applicant needs to make changes'.",
12431243
"FieldType": "Label",
12441244
"SecurityClassification": "Public",
12451245
"Searchable": "N"

service/src/integrationTest/java/uk/gov/hmcts/reform/fpl/controllers/ApproveDraftOrdersControllerValidateReviewDecisionMidEventTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ void shouldNotReturnErrorsWhenJudgeDoesNotReviewOneOfTheDraftOrdersInTheBundle()
156156
.reviewDraftOrdersData(reviewDraftOrdersData).build();
157157

158158
when(judicialService.isCurrentUserFeePaidJudge()).thenReturn(Boolean.FALSE);
159-
when(hearingOrderGenerator.addCoverSheet(caseData, order, draftOrder1)).thenReturn(orderWithCoverSheet);
159+
when(hearingOrderGenerator.addCoverSheet(caseData, order)).thenReturn(orderWithCoverSheet);
160160
AboutToStartOrSubmitCallbackResponse callbackResponse = postMidEvent(caseData, validateDecisionEventPath);
161161

162162
assertThat(callbackResponse.getErrors()).isEmpty();

service/src/main/java/uk/gov/hmcts/reform/fpl/model/docmosis/DocmosisApprovedOrderCoverSheet.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,5 @@ public class DocmosisApprovedOrderCoverSheet implements DocmosisData {
1515
private final List<DocmosisChild> children;
1616
private final String judgeTitleAndName;
1717
private final String dateOfApproval;
18-
private final String orderByConsent;
1918
private final String crest;
2019
}

service/src/main/java/uk/gov/hmcts/reform/fpl/service/cmo/ApproveDraftOrdersService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ public Map<String, Object> previewOrderWithCoverSheet(CaseData caseData) {
424424

425425
data.put("previewApprovedOrder" + labelCounter,
426426
hearingOrderGenerator.addCoverSheet(caseData, (approvedOrder.isConfidentialOrder()
427-
? approvedOrder.getOrderConfidential() : approvedOrder.getOrder()), orderElement));
427+
? approvedOrder.getOrderConfidential() : approvedOrder.getOrder())));
428428
data.put("previewApprovedOrderTitle" + labelCounter,
429429
String.format("Order %d %s", (i + 1), approvedOrder.getTitle()));
430430
labelCounter++;

service/src/main/java/uk/gov/hmcts/reform/fpl/service/cmo/HearingOrderGenerator.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public Element<HearingOrder> buildSealedHearingOrder(CaseData caseData,
6262

6363
if (addCoverSheet) {
6464
// add a sealed cover sheet to the order
65-
sealedOrder = documentSealingService.sealDocument(addCoverSheet(caseData, sealedOrder, hearingOrderElement),
65+
sealedOrder = documentSealingService.sealDocument(addCoverSheet(caseData, sealedOrder),
6666
caseData.getCourt(), caseData.getSealType());
6767
}
6868

@@ -81,11 +81,10 @@ public Element<HearingOrder> buildRejectedHearingOrder(
8181
.build());
8282
}
8383

84-
public DocumentReference addCoverSheet(CaseData caseData, DocumentReference orderDoc,
85-
Element<HearingOrder> hearingOrderElement) {
84+
public DocumentReference addCoverSheet(CaseData caseData, DocumentReference orderDoc) {
8685
try {
8786
DocmosisDocument orderWithCoverSheet = docmosisApprovedOrderCoverSheetService
88-
.addCoverSheetToApprovedOrder(caseData, orderDoc, hearingOrderElement);
87+
.addCoverSheetToApprovedOrder(caseData, orderDoc);
8988

9089
return buildFromDocument(uploadDocumentService
9190
.uploadPDF(orderWithCoverSheet.getBytes(), orderDoc.getFilename()));

service/src/main/java/uk/gov/hmcts/reform/fpl/service/docmosis/DocmosisApprovedOrderCoverSheetService.java

Lines changed: 5 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -10,32 +10,24 @@
1010
import org.springframework.stereotype.Service;
1111
import uk.gov.hmcts.reform.fpl.enums.docmosis.RenderFormat;
1212
import uk.gov.hmcts.reform.fpl.model.CaseData;
13-
import uk.gov.hmcts.reform.fpl.model.common.C2DocumentBundle;
1413
import uk.gov.hmcts.reform.fpl.model.common.DocmosisDocument;
1514
import uk.gov.hmcts.reform.fpl.model.common.DocumentReference;
16-
import uk.gov.hmcts.reform.fpl.model.common.Element;
1715
import uk.gov.hmcts.reform.fpl.model.configuration.Language;
1816
import uk.gov.hmcts.reform.fpl.model.docmosis.DocmosisApprovedOrderCoverSheet;
19-
import uk.gov.hmcts.reform.fpl.model.order.HearingOrder;
2017
import uk.gov.hmcts.reform.fpl.service.CaseDataExtractionService;
2118
import uk.gov.hmcts.reform.fpl.service.orders.generator.DocumentMerger;
2219
import uk.gov.hmcts.reform.fpl.service.time.Time;
2320

2421
import java.io.ByteArrayOutputStream;
2522
import java.io.IOException;
2623
import java.util.List;
27-
import java.util.Objects;
2824
import java.util.Optional;
29-
import java.util.stream.Stream;
3025

31-
import static uk.gov.hmcts.reform.fpl.enums.C2ApplicationType.WITHOUT_NOTICE;
3226
import static uk.gov.hmcts.reform.fpl.enums.DocmosisImages.CREST;
3327
import static uk.gov.hmcts.reform.fpl.enums.DocmosisTemplates.APPROVED_ORDER_COVER;
34-
import static uk.gov.hmcts.reform.fpl.enums.YesNo.YES;
3528
import static uk.gov.hmcts.reform.fpl.model.configuration.Language.WELSH;
3629
import static uk.gov.hmcts.reform.fpl.utils.DateFormatterHelper.DATE;
3730
import static uk.gov.hmcts.reform.fpl.utils.DateFormatterHelper.formatLocalDateToString;
38-
import static uk.gov.hmcts.reform.fpl.utils.ElementUtils.unwrapElements;
3931

4032
@Service
4133
@RequiredArgsConstructor(onConstructor = @__(@Autowired))
@@ -48,10 +40,9 @@ public class DocmosisApprovedOrderCoverSheetService {
4840
private final DocumentMerger documentMerger;
4941
private final Time time;
5042

51-
public DocmosisDocument addCoverSheetToApprovedOrder(CaseData caseData, DocumentReference order,
52-
Element<HearingOrder> hearingOrderElement) throws IOException {
43+
public DocmosisDocument addCoverSheetToApprovedOrder(CaseData caseData, DocumentReference order) throws IOException {
5344
// Create
54-
DocmosisDocument coverSheet = createCoverSheet(caseData, hearingOrderElement);
45+
DocmosisDocument coverSheet = createCoverSheet(caseData);
5546

5647
// Add cover sheet to the order
5748
DocmosisDocument orderWithCoverSheet = documentMerger.mergeDocuments(coverSheet, List.of(order));
@@ -94,25 +85,22 @@ public DocmosisDocument addCoverSheetToApprovedOrder(CaseData caseData, Document
9485
}
9586
}
9687

97-
public DocmosisDocument createCoverSheet(CaseData caseData, Element<HearingOrder> hearingOrder) {
98-
DocmosisApprovedOrderCoverSheet coverDocumentData = buildCoverDocumentsData(caseData, hearingOrder);
88+
public DocmosisDocument createCoverSheet(CaseData caseData) {
89+
DocmosisApprovedOrderCoverSheet coverDocumentData = buildCoverDocumentsData(caseData);
9990
return docmosisDocumentGeneratorService.generateDocmosisDocument(coverDocumentData,
10091
APPROVED_ORDER_COVER,
10192
RenderFormat.PDF,
10293
getCaseLanguage(caseData));
10394
}
10495

105-
public DocmosisApprovedOrderCoverSheet buildCoverDocumentsData(CaseData caseData,
106-
Element<HearingOrder> hearingOrder) {
107-
96+
public DocmosisApprovedOrderCoverSheet buildCoverDocumentsData(CaseData caseData) {
10897
return DocmosisApprovedOrderCoverSheet.builder()
10998
.familyManCaseNumber(caseData.getFamilyManCaseNumber())
11099
.courtName(caseDataExtractionService.getCourtName(caseData))
111100
.children(caseDataExtractionService.getChildrenDetails(caseData.getAllChildren()))
112101
.judgeTitleAndName(caseData.getReviewDraftOrdersData().getJudgeTitleAndName())
113102
.dateOfApproval(formatLocalDateToString(time.now().toLocalDate(), DATE, getCaseLanguage(caseData)))
114103
.crest(CREST.getValue())
115-
.orderByConsent(isC2OrderByConsent(caseData, hearingOrder) ? YES.getValue() : null)
116104
.build();
117105
}
118106

@@ -123,22 +111,4 @@ private String getAnnexText(CaseData caseData) {
123111
private Language getCaseLanguage(CaseData caseData) {
124112
return Optional.ofNullable(caseData.getC110A().getLanguageRequirementApplication()).orElse(Language.ENGLISH);
125113
}
126-
127-
private boolean isC2OrderByConsent(CaseData caseData, Element<HearingOrder> hearingOrder) {
128-
// 1. filter out all additional applications bundles by consent
129-
// 2. check if the hearing order id is present in any of the bundle
130-
return unwrapElements(caseData.getAdditionalApplicationsBundle()).stream()
131-
.anyMatch(additionalApplicationsBundle ->
132-
Stream.of(additionalApplicationsBundle.getC2DocumentBundle(),
133-
additionalApplicationsBundle.getC2DocumentBundleConfidential())
134-
.filter(Objects::nonNull)
135-
.filter(documentBundle -> WITHOUT_NOTICE.equals(documentBundle.getType()))
136-
.map(C2DocumentBundle::getDraftOrdersBundle)
137-
.filter(Objects::nonNull)
138-
.flatMap(List::stream)
139-
.anyMatch(draftOrderElement ->
140-
draftOrderElement.getValue().getDocument().getUrl()
141-
.equals(hearingOrder.getValue().getOrderOrOrderConfidential().getUrl()))
142-
);
143-
}
144114
}

service/src/test/java/uk/gov/hmcts/reform/fpl/service/cmo/HearingOrderGeneratorTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,7 @@ void shouldBuildSealedHearingOrderWhenReviewDecisionIsApproved() throws IOExcept
8686
.build();
8787

8888
when(documentSealingService.sealDocument(order, court, SealType.ENGLISH)).thenReturn(sealedOrder);
89-
when(docmosisApprovedOrderCoverSheetService.addCoverSheetToApprovedOrder(caseData, sealedOrder,
90-
element(ORDER_ID, hearingOrder)))
89+
when(docmosisApprovedOrderCoverSheetService.addCoverSheetToApprovedOrder(caseData, sealedOrder))
9190
.thenReturn(DOCMOSIS_DOCUMENT_ORDER_WITH_COVER_SHEET);
9291
when(uploadDocumentService.uploadPDF(eq(ORDER_WITH_COVER_SHEET_BYTES), any()))
9392
.thenReturn(ORDER_WITH_COVER_SHEET_DOCUMENT);
@@ -122,8 +121,7 @@ void shouldBuildSealedHearingOrderWhenJudgeAmendsTheDocument() throws IOExceptio
122121
.reviewCMODecision(reviewDecision)
123122
.build();
124123
when(documentSealingService.sealDocument(amendedOrder, court, SealType.ENGLISH)).thenReturn(sealedOrder);
125-
when(docmosisApprovedOrderCoverSheetService.addCoverSheetToApprovedOrder(caseData, sealedOrder,
126-
element(ORDER_ID, hearingOrder)))
124+
when(docmosisApprovedOrderCoverSheetService.addCoverSheetToApprovedOrder(caseData, sealedOrder))
127125
.thenReturn(DOCMOSIS_DOCUMENT_ORDER_WITH_COVER_SHEET);
128126
when(uploadDocumentService.uploadPDF(eq(ORDER_WITH_COVER_SHEET_BYTES), any()))
129127
.thenReturn(ORDER_WITH_COVER_SHEET_DOCUMENT);

service/src/test/java/uk/gov/hmcts/reform/fpl/service/docmosis/DocmosisApprovedOrderCoverSheetServiceTest.java

Lines changed: 2 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
import static org.mockito.BDDMockito.given;
3838
import static uk.gov.hmcts.reform.fpl.enums.DocmosisImages.CREST;
3939
import static uk.gov.hmcts.reform.fpl.enums.DocmosisTemplates.APPROVED_ORDER_COVER;
40-
import static uk.gov.hmcts.reform.fpl.enums.YesNo.YES;
4140
import static uk.gov.hmcts.reform.fpl.utils.DateFormatterHelper.DATE;
4241
import static uk.gov.hmcts.reform.fpl.utils.DateFormatterHelper.formatLocalDateToString;
4342
import static uk.gov.hmcts.reform.fpl.utils.ElementUtils.element;
@@ -131,7 +130,7 @@ void shouldGenerateApprovedOrderCoverSheet() {
131130
RenderFormat.PDF, LANGUAGE))
132131
.willReturn(COVER_SHEET);
133132

134-
DocmosisDocument result = underTest.createCoverSheet(caseData, HEARING_ORDER);
133+
DocmosisDocument result = underTest.createCoverSheet(caseData);
135134

136135
assertThat(result).isEqualTo(COVER_SHEET);
137136
}
@@ -172,50 +171,10 @@ void shouldAddCoverSheetAndAddAnnexAWording() throws IOException {
172171
DocmosisDocument mergedOrder = new DocmosisDocument("merged_order.pdf", mergedOrderBytes);
173172
given(documentMerger.mergeDocuments(any(), any())).willReturn(mergedOrder);
174173

175-
DocmosisDocument result = underTest.addCoverSheetToApprovedOrder(caseData, testDocumentReference(),
176-
HEARING_ORDER);
174+
DocmosisDocument result = underTest.addCoverSheetToApprovedOrder(caseData, testDocumentReference());
177175

178176
String resultText = (new DocmosisHelper()).extractPdfContent(result.getBytes());
179177

180178
assertThat(resultText).isEqualToNormalizingWhitespace("First page Second page ANNEX A: ");
181179
}
182-
183-
@Test
184-
void shouldAddCoverSheetWithConsentWording() {
185-
CaseData caseData = CaseData.builder()
186-
.id(CASE_ID)
187-
.familyManCaseNumber(FAMILY_MAN_NUMBER)
188-
.court(COURT)
189-
.c110A(C110A.builder()
190-
.languageRequirementApplication(LANGUAGE)
191-
.build())
192-
.children1(List.of(CHILD))
193-
.confidentialChildren(List.of(CONFIDENTIAL_CHILD))
194-
.reviewDraftOrdersData(ReviewDraftOrdersData.builder().judgeTitleAndName(JUDGE_NAME).build())
195-
.additionalApplicationsBundle(List.of(C2_BUNDLE_WITH_CONSENT))
196-
.build();
197-
198-
given(caseDataExtractionService.getCourtName(caseData)).willReturn(COURT_NAME);
199-
given(caseDataExtractionService.getChildrenDetails(caseData.getAllChildren())).willReturn(DOCMOSIS_CHILDREN);
200-
given(time.now()).willReturn(TEST_TIME);
201-
202-
DocmosisApprovedOrderCoverSheet expectedDocmosisData = DocmosisApprovedOrderCoverSheet.builder()
203-
.familyManCaseNumber(FAMILY_MAN_NUMBER)
204-
.courtName(COURT_NAME)
205-
.children(DOCMOSIS_CHILDREN)
206-
.judgeTitleAndName(JUDGE_NAME)
207-
.dateOfApproval(formatLocalDateToString(TEST_TIME.toLocalDate(), DATE, Language.ENGLISH))
208-
.crest(CREST.getValue())
209-
.orderByConsent(YES.getValue())
210-
.build();
211-
212-
213-
given(docmosisDocumentGeneratorService.generateDocmosisDocument(expectedDocmosisData, APPROVED_ORDER_COVER,
214-
RenderFormat.PDF, LANGUAGE))
215-
.willReturn(COVER_SHEET);
216-
217-
DocmosisDocument result = underTest.createCoverSheet(caseData, HEARING_ORDER_WITH_CONSENT);
218-
219-
assertThat(result).isEqualTo(COVER_SHEET);
220-
}
221180
}

0 commit comments

Comments
 (0)