Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AstyanaxClient #21

Open
boneill42 opened this issue Feb 8, 2013 · 2 comments
Open

Refactor AstyanaxClient #21

boneill42 opened this issue Feb 8, 2013 · 2 comments
Milestone
0.4.0 Release

Comments

@boneill42
Copy link
Contributor

There is lots of code duplication in AstyanaxClient to support both TridentTuples as well as Storm tuples. There has to be a better way to do that as not to repeat so much code.
@ptgoetz
Copy link
Contributor

ptgoetz commented Feb 8, 2013

I'm on the fence as to whether we want to break it into two classes, but agree that there's lots of room for cleanup/refactoring.

Since TridentTuple and Tuple are completely disparate, we'd likely have to use reflection, to make it generic.

Whatever we decide on, let's get it done for 0.4.0

@boneill42
Copy link
Contributor Author

Agreed. Changed title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0 Release
Development

No branches or pull requests
2 participants
@ptgoetz @boneill42