Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CLI options for better Dockerization #61

Closed
bertsky opened this issue Mar 14, 2023 · 2 comments
Closed

add CLI options for better Dockerization #61

bertsky opened this issue Mar 14, 2023 · 2 comments

Comments

@bertsky
Copy link
Contributor

bertsky commented Mar 14, 2023

In the Docker/broadwayd setting, it would be nice if we could arrange for the GUI to

  • start maximized (like gnome-terminal --maximized)
  • hide the Open button (so the Web access does not get to see the whole filesystem)
  • hide the Edit functionalities (so the Web access becomes read-only)
@SvenMarcus
Copy link

We could also consider disabling the entire window decorations, see: https://valadoc.org/gtk+-3.0/Gtk.Window.set_decorated.html

@hnesk hnesk closed this as completed in e4efaff Apr 5, 2023
@hnesk
Copy link
Owner

hnesk commented Apr 5, 2023

Together with commit 67b5316 this allows for command lines like:
browse-ocrd --fullscreen --restricted mets.xml or with short flags: browse-ocrd -fr mets.xml
There are four new options:

$ browse-ocrd --help
...
  -v, --version               Show version and exit
  -m, --maximize              Open in maximized window
  -f, --fullscreen            Open in fullscreen window
  -r, --restricted            Open restricted (no edit/open functionality)
...

I tried to disable window decorations as in #61 (comment) but the effect is quite similar to --fullscreen without filling the screen, and I think --fullscreen is the better option for any usecase, but I'm open to support disabling the window decorations, if you think it's still needed

Edit: renamed readonly to restricted, readonly sounds more edit-mode related than it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants