-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Github tag "stable" is referencing an old version #2081
Comments
The tag "stable" still shows to a very old release: https://github.com/ho-dev/HattrickOrganizer/releases/tag/stable #2090 is another issue concerning out builds. |
Do you know if what commit you changed the “development stage” to |
Ah, see it know: a30d8f1 |
and the corresponding build: |
Yeah, the release is a big mess, with 7.3 artefacts with 8.0: |
https://github.com/ho-dev/HattrickOrganizer/releases/tag/8.0 this one is OK |
Weirdly the tag is marked has having been created by akasolace, which is odd because the 8.0 release uses the correct PAT it seems. |
Still no joy. It works locally (the DEV suffix no longer appears, but it seems it is still there in the latest release). I'll have to spend time on this this evening. |
Now the tag 8.0 is also wrong : https://github.com/ho-dev/HattrickOrganizer/releases/tag/8.0 |
That bit makes sense at least, since the release ran again, right? |
@wsbrenk I am not entirely sure I know/remember the process for a release. Is it possible to make a new release of 8.0? |
I think, we should make this possible. Going to a new version without any bug fixes or new features is no good idea in my opinion. |
now the list of assets in 8.0 includes DEV and stable items. is the destination of the build process kind of cache? Old builds still existing and we have to clean the directory before building a new release???? |
It shouldn't: unless something changed, which I am not aware of, it spins up a new container to build every time. I think it merges the assets from the previous tag. I am going to experiment on the test project I have, but it's quite intriguing... |
What steps do you follow when you create a new release? |
First problem (the persistent groovy:000> "" ?: "pouet"
===> pouet Will remove the operator, as the line above sets the index by default. |
For the second issue, it seems to be the “Publish Release” task that's pushing way more than expected to the release: Looking into why now. |
I think this is caused by this line in “Delete previous tag and release” task:
The GH task doesn't seem to be able to delete the previous release for that tag. |
Really weird behaviour: when deleting the tags manually, all good, but the release looks like pre-release. Then the next one is all weird again, and oddly created by akasolace, which make no sense to me. |
It appears that the So for releases that have the same name (i.e. |
Ok, after a loooot of messing, this seems to be addressed, the latest release seems ok. I'll propose a PR upstream when I get a chance. Now the |
I'm not really familiar with the GitHub tags and releases either. But it looks like releases/latest is automatically available. No idea why we additionally built a stable and tag_stable. |
I'm currently thinking about what to do with the bug fixes that have been reported to us. Actually, they should lead to at least one version 8.1. To include this in 8.0 would actually be botched. On the other hand, a little botched work isn't so bad - is it? |
I think having a version 8.1 is fine. Let's leave 8.0 alone, as it has suffered enough. It would also validate the various release flows. |
I found a link in "unwritten manual" referencing this tag.
Should reference to the same version as "tag_stable".
github release action should set the stable tag too when a new stable version is released.
The text was updated successfully, but these errors were encountered: