Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.5.3 is a breaking change #88

Open
ivolucien opened this issue Oct 16, 2018 · 1 comment
Open

v0.5.3 is a breaking change #88

ivolucien opened this issue Oct 16, 2018 · 1 comment

Comments

@ivolucien
Copy link

v0.5.1...v0.5.3#diff-e41c65498b26286ad5bf2a9f21ff0722R79

This above code changes the default encoding that breaks callers who depend on the old handling.

In our case the header specifies an encoding that is not RS256 which the new code ignores.

I suggest that you rev the minor version, with an explanation of the change in the README.md

That at least will spare folks the research into why decoding is broken (for that subset of users.)

Thank you much

@ivolucien
Copy link
Author

I realize that semver would dictate the major version be rev'd for non-backwards compatible changes, but I can imagine you might not want to release v1.0.0 with only that announcement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant