Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: opts.unsafeDisableEncryption #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: opts.unsafeDisableEncryption #25

wants to merge 1 commit into from

Conversation

gmaclennan
Copy link
Contributor

Adds an option to disable encryption. This is useful for piping over a
transport stream that is already encrypted, but the handshake to confirm
public keys is still useful.

Fixes #21

@gmaclennan
feat: opts.unsafeDisableEncryption
2dd8b51 
Adds an option to disable encryption. This is useful for piping over a
transport stream that is already encrypted, but the handshake to confirm
public keys is still useful.
@gmaclennan gmaclennan mentioned this pull request Jan 17, 2024
Open
@gmaclennan
Copy link
Contributor Author

In terms of encryption overhead, one of the tests write 1GB of data to the stream. On my machine (Macbook Pro M2) this takes ~4100ms, but without encryption takes ~200ms.

@gmaclennan
Copy link
Contributor Author

ping @mafintosh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

encryption: false option?
1 participant
@gmaclennan