Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More control over when buffer gets flushed #4

Open
msaspence opened this issue Jul 22, 2016 · 2 comments
Open

More control over when buffer gets flushed #4

msaspence opened this issue Jul 22, 2016 · 2 comments

Comments

@msaspence
Copy link

Currently the buffer is flushed every 5 seconds, more complex models may be nice to have:

  • max buffer time - if buffer hasn't been flushed by this it will be
  • min buffer time - after a metric is tracked the script would wait this amount of time before flushing buffer, if a new metric is tracked in that time it will delay it another min buffer time
  • min buffer size - the buffer won't flush it is smaller than this
  • max buffer size - the buffer will flush at this size regardless of other considerations
@theninj4
Copy link
Contributor

This sounds great - we could set sensible defaults and let users override as necessary. These changes may need to come after some of the other network optimisation stuff, right now the numbers are aligned to mitigate any possible network performance issues. It could be possible to tweak the above options and introduce performance issues.

@msaspence
Copy link
Author

This functionality could also be loaded in a second phase, i.e. the embedded script has a super simple implementation to save bytes. A "phase two" script could replace this with an implementation with more options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants