Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support VariableAware delegates and listeners #55

Open
jangalinski opened this issue Jul 3, 2020 · 2 comments
Open

support VariableAware delegates and listeners #55

jangalinski opened this issue Jul 3, 2020 · 2 comments
Assignees
Labels
Type: enhancement New feature or request
Milestone

Comments

@jangalinski
Copy link
Contributor

Scenario

with the introduction of VariableReader and VariableWriter in 1.0.0 ... let's go one step further. Why should we use the default camunda delegate/listener API, when we could directly do:

@Bean
  fun writeOrderTotal() = VariableAwareExecutionListener { execution ->
    val total = execution.get(ORDER_TOTAL)
    execution.set(ORDER_TOTAL, total)
  }

Current Behaviour

VARIABLE.on(execution).set(value)

Wanted Behaviour

execution.set(VARIABLE, value)

@jangalinski jangalinski added Type: enhancement New feature or request State: in progress Assignee is working on the issue. labels Jul 3, 2020
@jangalinski jangalinski self-assigned this Jul 3, 2020
@jangalinski jangalinski added this to the 1.1.0 milestone Jul 3, 2020
@zambrovski
Copy link
Member

Wht is the main motivation to creatge an own API instead of using existing one?
Is there something I can do better with it? Can you provide some insights please?

Contra: I'll have to learn and educate an additional API (instead of a de-facto standard one introduced by Camunda), make all tools work with it (testing, mocking, etc...)

@zambrovski
Copy link
Member

By the way - this API change is relevant for Java only, so no need to do it for kotlin this way.

@zambrovski zambrovski modified the milestones: 1.1.0, BACKLOG Aug 25, 2020
@zambrovski zambrovski removed the State: in progress Assignee is working on the issue. label Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants