Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test for sheafification #75

Open
mohamed-barakat opened this issue Feb 23, 2021 · 3 comments
Open

Improve test for sheafification #75

mohamed-barakat opened this issue Feb 23, 2021 · 3 comments

Comments

@mohamed-barakat
Copy link
Member

There are other simpler tests for "does sheafify to zero" which can be added before going for the final test here. One of them is to test the dimension of the module using the command AffineDimension.

@HereAround
Copy link
Member

Thank you @mohamed-barakat. Is AffineDimension already supported for the FPGradedModules via FreydCategories?

If not, I support a conversion amog the f.p. graded module implementation in GradedModules and those in FreydCategories in https://github.com/homalg-project/ToricVarieties_project/blob/master/ToolsForFPGradedModules/gap/Conversion.gd. One way to implement your suggestion is thus to overload this (and if needed more) functionality.

@mohamed-barakat
Copy link
Member Author

No, in the case of left modules you have to extract the matrix of relations and apply AffineDimension to it. In the case of right modules, you have to transpose it first before applying AffineDimension.

I am now working on a package called IntrinsicGradedModules which should at some point replace GradedModules but is now based on FPGradedModules and in particular CAP-based. This package will include some enhancements for FPGradedModules. Once the package is stable I will make PRs to FreydCategoriesForCAP including these enhancements.

@HereAround
Copy link
Member

HereAround commented Mar 3, 2021

Thank you for elaborating @mohamed-barakat. The structure makes sense to me. However, this will take time. Furthermore, currently the sheafification is merely a "container" for FPGradedModules. None of the implemented algorithms benefits from it. I hope this changes at some point in the future...

Consequently, to me this seems not a high priority at this point. Please keep me posted. Once you have the relevant structures/packages ready, I am happy to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants