Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

production server detection shall be enhanced #913

Closed
waclaw66 opened this issue Oct 4, 2024 · 1 comment · May be fixed by #940
Closed

production server detection shall be enhanced #913

waclaw66 opened this issue Oct 4, 2024 · 1 comment · May be fixed by #940

Comments

@waclaw66
Copy link

waclaw66 commented Oct 4, 2024

Production server detection doesn't cover following use case.

  • Home Assistant Container
  • python-matter-server running in Docker
  • custom ingress (HACS hass_ingress) configuration:
    /var/lib/homeassistant/ingress/matter_server.yaml
require_admin: true
ui_mode: toolbar
title: Matter Server
icon: mdi:puzzle
url: http://127.0.0.1:5580

obrazek

Production server detection fails then because it's requiring either of these two conditions that are not fulfilled because lovelylain/hass_ingress is building ingress URL like /api/ingress/[app_name].

I would suggest to add another condition location.href.includes("/api/ingress/").

Thanks in advance.

@marcelveldt
Copy link
Contributor

That is out of scope of our development for now, feel free to open a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants