Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various string updates needed for translations #4823

Open
NoRi2909 opened this issue Nov 17, 2024 · 4 comments
Open

Various string updates needed for translations #4823

NoRi2909 opened this issue Nov 17, 2024 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@NoRi2909
Copy link

Home Assistant Android app version:
2024.11.4-full (beta)

Android version:
15

Device model:
Pixel 6

Home Assistant version:
2020.11.2

Description of problem, include YAML if issue is related to notifications:

When adding an Picture widget, the popup menu for the Tap action offers two options:

  • Refresh
  • Open

Screenshot_20241117-203433

The two strings these come from seem to be

  • refresh
  • state_open

While in English the state "open" is spelled exactly like the action "open" this does not work in other languages.
In German the state is "offen" while the action is "öffnen".

So we need a separate open string for the action.

@NoRi2909 NoRi2909 added the bug Something isn't working label Nov 17, 2024
@dshokouhi dshokouhi added the good first issue Good for newcomers label Nov 17, 2024
@NoRi2909
Copy link
Author

Side note as it's a similar problem for translation:
The finish string is meant as the verb, I assume?

So far I haven't found that in the UI.
But it's currently translated as "Fertig", meaning "done" which I assume is incorrect.

@NoRi2909
Copy link
Author

And two more strings for a little consistency cleanup:

"Get total calories burned from Health Connect"
"Get active calories burned from Health Connect"

These are inconsistent with all the other Health Connect sensors that don't use "Get …"
So you can just drop it on these two as well.

In German the verb is a bit longer with "abrufen" and changes the grammar.

@dshokouhi
Copy link
Member

"Get total calories burned from Health Connect"

Actually this one needs to be completely updated to match the other daily health connect sensors since it also resets at midnight

"Get active calories burned from Health Connect"

For this one we should match the others with "Last recorded ...."

@dshokouhi
Copy link
Member

The finish string is meant as the verb, I assume?

This one looks unused on first glance

@dshokouhi dshokouhi changed the title Separate string for action "open" needed for translations Various string updates needed for translations Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants