checks for supported commands

Author: bwp91

lib/govee.js

@@ -105,17 +105,20 @@ class Govee {
       }
       if ((accessory = this.devicesInHB.get(device.device))) {
         accessory.context.controllable = device.controllable
+        accessory.context.retrievable = device.retrievable
         accessory.context.supportedCmds = device.supportCmds
         const res = await this.httpClient.getDevice(accessory.context)
-        this.refreshAccessory(accessory, Object.assign({}, ...res))
+        if (accessory.context.retrievable) {
+          this.refreshAccessory(accessory, Object.assign({}, ...res))
+        } else {
+          throw new Error('requesting status is unsupported for the ' + device.model)
+        }
       } else {
-        this.log.warn("[%s] could not be initialised as it wasn't found in Homebridge.", device.deviceName)
+        throw new Error("it wasn't found in Homebridge.")
       }
     } catch (err) {
       if (this.debug) {
-        let str = err.message
-        if (str === 'Request failed with status code 400') str += '. This error can often be safely ignored if device control is working as expected'
-        this.log.warn('[%s] could not be updated as %s.', device.deviceName, str)
+        this.log.warn('[%s] could not be updated as %s.', device.deviceName, err.message)
       }
     }
   }
@@ -209,6 +212,12 @@ class Govee {
   async internalOnOffUpdate (accessory, value, callback) {
     callback()
     try {
+      if (!(
+        accessory.context.controllable &&
+        accessory.context.supportedCmds.includes('turn')
+      )) {
+        throw new Error('model [' + accessory.context.gvModel + '] does not support command [turn]')
+      }
       await this.httpClient.updateDevice(accessory.context, {
         name: 'turn',
         value: value ? 'on' : 'off'
@@ -218,13 +227,19 @@ class Govee {
       }
       this.ignoreNextSync = true
     } catch (err) {
-      this.log.warn('[%s] could not be updated and its status will be reverted soon. Error: \n%s.', accessory.displayName, err)
+      this.log.warn('[%s] could not be updated and its status will be reverted soon. Error: %s.', accessory.displayName, err.message)
     }
   }
 
   async internalBrightnessUpdate (accessory, value, callback) {
     callback()
     try {
+      if (!(
+        accessory.context.controllable &&
+        accessory.context.supportedCmds.includes('brightness')
+      )) {
+        throw new Error('model [' + accessory.context.gvModel + '] does not support command [brightness]')
+      }
       await this.httpClient.updateDevice(accessory.context, {
         name: 'brightness',
         value: value
@@ -234,13 +249,19 @@ class Govee {
       }
       this.ignoreNextSync = true
     } catch (err) {
-      this.log.warn('[%s] could not be updated and its status will be reverted soon. Error: \n%s.', accessory.displayName, err)
+      this.log.warn('[%s] could not be updated and its status will be reverted soon. Error: %s.', accessory.displayName, err.message)
     }
   }
 
   async internalColourUpdate (accessory, value, callback) {
     callback()
     try {
+      if (!(
+        accessory.context.controllable &&
+        accessory.context.supportedCmds.includes('color')
+      )) {
+        throw new Error('model [' + accessory.context.gvModel + '] does not support command [color]')
+      }
       const lightService = accessory.getService(Service.Lightbulb)
       const curSat = lightService.getCharacteristic(Characteristic.Saturation).value
       const newRGB = cConvert.hsv.rgb(value, curSat, 100)
@@ -258,7 +279,7 @@ class Govee {
       }
       this.ignoreNextSync = true
     } catch (err) {
-      this.log.warn('[%s] could not be updated and its status will be reverted soon. Error: \n%s.', accessory.displayName, err)
+      this.log.warn('[%s] could not be updated and its status will be reverted soon. Error: %s.', accessory.displayName, err.message)
     }
   }
 }