Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Homebridge and Homebridge UI versions in update center #2273

Open
justjam2013 opened this issue Dec 9, 2024 · 4 comments
Open

Show Homebridge and Homebridge UI versions in update center #2273

justjam2013 opened this issue Dec 9, 2024 · 4 comments

Comments

@justjam2013
Copy link
Contributor

justjam2013 commented Dec 9, 2024

Feature Description

What is happening?

Currently, Update Center is showing a grey "Up to Date" string for Homebridge, Homebridge UI, and Node.js:
Screenshot 2024-12-09 at 11 05 51 PM

This doesn't add much to the UI, as it is a light grey and not as eye-catching as the checkmark icon (and the icon is a more immediate indicator that all is fine than reading). If there is an update available, it shows a highlighted "Update Available" and the check mark icon is replaced with an upward pointing arrow icon:
Screenshot 2024-12-09 at 11 06 14 PM

What you expect to happen?

When there are no updates available, show the current version for Homebridge, Homebridge UI, and Node.js, instead of "Up to Date".

What problems would this new feature solve?

Primarily it maximizes the real estate on the Status page, by displaying useful information on the UI.

And it reduces the extra clicks, for filling out the Bug template, which asks for Homebridge, Homebridge UI, and Node.js versions. 😁

@justjam2013
Copy link
Contributor Author

justjam2013 commented Dec 9, 2024

Outdated: New PR opened on branch beta-5.0.0

I looked at the code, but I am not sure what the syntax is supposed to be.
The following substitutions should be done:

For Homebridge version:


to

              v{{ $settings.env.homebridgeVersion }}

For Homebridge UI version:


to

              v{{ $settings.env.homebridgeUiVersion }}

Still working on where Node.js display is located.

@justjam2013
Copy link
Contributor Author

justjam2013 commented Dec 10, 2024

Outdated: New PR opened on branch beta-5.0.0

Opened PR with changes for displaying Homebridge and Homebridge UI version: Show Homebridge & Homebridge UI versions in Update Center #2275

@justjam2013
Copy link
Contributor Author

I was looking at the latest branch, not the beta-5.0.0 branch!

For Homebridge version:


should be:

            <span> v{{ $settings.env.homebridgeVersion }} </span>

For Homebridge UI version:


should be:

            <span> v{{ $settings.env.homebridgeUiVersion }} </span>

For Node.js version:

<span class="grey-text small"> {{ 'status.homebridge.up_to_date' | translate }} </span>

should be:

          <span class="grey-text small"> v{{ $settings.env.nodeVersion }} </span>

@justjam2013
Copy link
Contributor Author

Closed original PR, as the change should have been made on branch beta-5.0.0.
Opened new PR on branch beta-5.0.0: Show Homebridge & Homebridge UI versions in Update Center (beta)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant