New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty select element options are considered invalid #2296

Open

dnicolson opened this issue Dec 27, 2024 · 0 comments

Labels

bug

Contributor

dnicolson commented Dec 27, 2024

Describe The Bug

Empty values are used in this project (although this might not be in use):
https://github.com/homebridge/homebridge-config-ui-x/blob/57246cf/config.schema.json#L439

And also here:
https://github.com/OpenWonderLabs/homebridge-switchbot/blob/e9bbc7d/config.schema.json#L357

This could be fixed by replacing hasValue with isDefined here:
https://github.com/zahmo/ng-formworks/blob/32f31f507150857d530b3c667716a1ee9a8cf87c/projects/ng-formworks-core/src/lib/shared/json.validators.ts#L154

Logs

No response

Config

No response

Homebridge UI Version

Latest branch

Homebridge Version

v1.8.4

Node.js Version

v20.11.1

Operating System

macOS

Environment Info

None

Raspberry Pi Model

None

The text was updated successfully, but these errors were encountered:

dnicolson added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment